Bug 151956

Summary:	red eye enhance feature no longer works
Product:	[Applications] digikam	Reporter:	R Clarke <cnrpub>
Component:	Faces-RedEyes	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	gerhard, tedhansen
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:	0.9.3
Sentry Crash Report:
Attachments:	context help strings

Description R Clarke 2007-11-06 20:50:51 UTC

Version: 0.6.0 (using KDE KDE 3.5.8)
Installed from: Ubuntu Packages
OS: Linux

I've been using showfoto for several revisions now, and really like this application. My main reason for using it is it is the only linux application I am aware of with an easy red eye fix capability. In fact, I've recommended it on several occasions when the question of red eye reduction in linux is asked on linux forums. I just upgraded from Kubuntu 7.04 to kubuntu 7.10, and installed showfoto from the standard repositories. Now when I go to reduce red eye in showfoto, nothing (noticeable) happens to the red in the eyes. I see there is a new interface for this function, but aside from adding a great deal of complexity I don't see any benefit. In previous versions all I had to do is zoom in a bit, select the eye closely, and use the red eye reduction feature using the "aggressive" option. Now when I select the eye and open the red eye reduction function, no noticeable change happens to the red in the eye. Just to make sure I didn't have a special photo with especially tricky red eye, I rebooted to my old kubuntu partition and used showfoto 0.5. This worked like a charm on the red eyes in the photo. In the new version I'm using the default settings that come up because I don't have a clue as to what I should be doing with the interface. However, even if this is "user error", this would beg the question of why the program moved from a very simple to use feature, to one which requires a large amount of user input. Why not keep the simple (and effective) preset options (mild and aggressive), while allowing power users the option to hand tune these settings further?

Comment 1 caulier.gilles 2007-11-06 21:26:44 UTC

Clarke,

This is not a regression of this tool (:=)))

You just misunderstood how it work...

The improvements are :

- A preview of effect using same dialog/tools than others image editor tools.
- "Sensitivity" setting is to adjust the level of red eyes removal (agressive or not).
- "Smooth" setting is to blur the border of pixels wich have been changed to give a pupil more natural.
- "Color Tint" setting is to set a custom color to re-colorize the eyes. The old version give only a black hole if you remember. If you want blue eyes insted red eyes, you can do it. If you want a black hole like old one, just select black color in selector.
- "Tint Level" setting is to adjust the luminosity of the new pupil color.

To have a preview of effect, just push the right button on the top/left of the dialog. My prefered is on mouse over.

http://docs.kde.org/development/en/extragear-graphics/digikam/photographic-editing.html#using-redeyecorrection

The tool work exactly like the old one. It's the same algorithm + more adjustments added. Like the old one, you must select the eyes area before to use it.

Gilles Caulier

Comment 2 R Clarke 2007-11-07 21:39:03 UTC

Thanks for the clarification (and such a quick response!).  Your bullet points help a great deal, and would make a good addition to the documentation you link to.  I spent some time using the settings and can now achieve better results.  However, I still can't find the settings that were used for the "aggressive" option.  Can you share what should be in each setting to duplicate the old preset aggressive option?

Comment 3 caulier.gilles 2007-11-07 23:00:24 UTC

Gerhard,

Can you add my preview comments to the handbook please...

Thanks in advance

Gilles

Comment 4 Achim Bohnet 2007-11-08 11:14:45 UTC

FWIW:  Gilles a-bit-longer descriptions above are much better than
what one gets with the shift-F1-click help.   So I favour:

  o adding to doc and shift-f1 help text

  o at least in 0.9.3 'color tint' has no shift-f1 help at all

Comment 5 Gerhard Kulzer 2007-11-08 14:44:34 UTC

Gilles, I added your points to the description. 
Thanks
Gerhard

Comment 6 Arnd Baecker 2007-11-13 14:29:45 UTC

Created attachment 22045 [details]
context help strings

A few cosmetic changes to the SHIFT-F1 help.
QWhatsThis added to "Coloring Tint".

Comment 7 caulier.gilles 2007-11-13 14:35:28 UTC

Let's go Arnd (:=)))... You don't need to make a patch to fix strings stuff (typo, grammar, english words, whatthis, tooltips, etc...)

Gilles

Comment 8 caulier.gilles 2007-11-16 12:55:04 UTC

SVN commit 737500 by cgilles:

digiKam from KDE3 branch : improvement of settings description from Red Eyes coorection tool.
CCBUGS: 151956


 M  +9 -5      imageeffect_redeye.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=737500

Comment 9 caulier.gilles 2007-11-16 13:02:39 UTC

SVN commit 737506 by cgilles:

backport commits #737500 from KDE3 branch
BUG: 151956



 M  +13 -9     imageeffect_redeye.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=737506

Comment 10 caulier.gilles 2007-12-11 07:18:58 UTC

*** Bug 153823 has been marked as a duplicate of this bug. ***