Bug 150598

Summary: File rename during image upload fails silently
Product: [Applications] digikam Reporter: Paul Waldo <paul>
Component: AdvancedRename-ImportAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 0.9.2   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In: 1.0.0
Sentry Crash Report:

Description Paul Waldo 2007-10-08 14:19:29 UTC 
Version:           0.9.2-final (using KDE 3.5.6, Kubuntu (feisty) 4:3.5.6-0ubuntu14.1)
Compiler:          Target: x86_64-linux-gnu
OS:                Linux (x86_64) release 2.6.20-16-generic

During upload of images from camera, final file names are are temporary file names like "PQTBTU~V.JPG", and no indication is given that there is a problem giving the file the expected name.

This happens because the file name template produces file names that are invalid for the file system.  In my particular case, I am storing the images on a networked CIFS share.  I chose "ISO" for the Date Format, producing a desired file name like this: "photo2007-10-06T17:28:12-000003.crw".  Colons are not allowed for CIFS (FAT32) file systems, so renaming the temporary file to the final name fails.  This is reasonable that it should fail, but there is no indication that it has failed.  I would expect a dialog indicating failure, with the chance to abort or manually rename.

This may be difficult to duplicate if the underlying file system is ext2, as the file name characters allowed are anything but NULL and /.
Comment 1 caulier.gilles 2007-10-08 14:30:33 UTC 
Paul,

Try to reproduce the problem with current implementation from svn (0.9.3-beta1) . i have fixed several problem with FAT32 filesystem...

Gilles Caulier
Comment 2 Paul Waldo 2007-10-10 14:52:03 UTC 
No luck.  I got the SVN code as of 10/10 and the problem still exists.  What should I have expected to happen?  Does Digikam give a dialog or automatically choose a valid file name?
Comment 3 caulier.gilles 2008-03-18 22:08:29 UTC 
Yes Paul, it must do it...

Are you tried current svn implementation, or at least 0.9.3 final ?

Gilles Caulier
Comment 4 caulier.gilles 2008-12-05 13:19:33 UTC 
Paul,

What's news about this file ? It still valid using digiKam 0.9.4 ?

Gilles Caulier
Comment 5 caulier.gilles 2009-05-13 10:33:03 UTC 
Paul, We need fresh news abou tthis entry. 

Can you test using 0.10.0, or better with current implementation from svn (0.11) ?

Gilles Caulier
Comment 6 Paul Waldo 2009-05-14 03:49:50 UTC 
Just tried on Version 0.11.0-svn (rev.: 967687)
Using KDE 4.2.2 (KDE 4.2.2)

When using 0.10.0, my uploaded photos were named like this: "photo2009-05-06_17-39-59-000010.CRW"
After getting the SVN version and uploading using the same procedure, now my files are (incorrectly) named like this:
"-10.CRW"

It looks like my settings for uploading are still the same, with the date format looking like this:
yyyy-MM-dd_hh-mm-ss

Something broke in the file renaming code?
Comment 7 Paul Waldo 2009-05-14 03:53:04 UTC 
Another data point:
In the file upload dialog, it tells me the name of the file as it will appear on disk.  For the SVN 0.11.0 version, it says
"New Name: .CRW"
Comment 8 caulier.gilles 2009-05-26 09:55:56 UTC 
Andi, 

I think this file is fixed. right ?

Gilles
Comment 9 Andi Clemens 2009-05-26 10:05:00 UTC 
I don't think so, this has nothing to do with the manual rename widget.

Paul,
which renaming options are you using? Can you make a screenshot of the exact settings?
I guess you are using the "Customize" options, but we need to be sure for further tests.

Andi
Comment 10 Paul Waldo 2009-06-05 17:44:54 UTC 
I was able to inadvertently confirm that this issue is fixed.  I use Date Based image upload and somehow it got set to "Local".  This would have produced a filename something like this: "photo-2009/06/05-blahblahblah".  This is obviously not a correct file name and I was warned with a dialog saying that the file name cannot contain a "/".  Great job!  Thanks.