Bug 150371

Summary:	Identity widget does not listen to account status changes
Product:	[Unmaintained] kopete	Reporter:	Dennis Nienhüser <nienhueser>
Component:	Main Application	Assignee:	Kopete Developers <kopete-bugs-null>
Status:	RESOLVED WORKSFORME
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	identitystatuswidget.diff identitystatuswidget_2.cpp.diff

Description Dennis Nienhüser 2007-10-01 11:44:30 UTC

Version:            (using KDE Devel)
Installed from:    Compiled sources

I'm using the identity widget at the bottom of the main window to connect to / disconnect from my different accounts. It doesn't reflect status changes (e.g. offline->online) though unless I hide and show it again.

Comment 1 Dennis Nienhüser 2007-10-01 11:52:54 UTC

Created attachment 21725 [details]
identitystatuswidget.diff

The patch moves the account status label text update to its own slot and
connects the global account online status signal to it.

I left the 
//TODO: online status 
comment in the code as there might be other things to do. The slot could as
well be named slotUpdateOnlineStatus instead of slotUpdateAccountStatus.

Comment 2 Matt Rogers 2007-10-03 19:46:11 UTC

SVN commit 720777 by mattr:

Fix bug 150371

The identity widget now listens to account status changes and updates itself
accordingly.

Patch by Dennis Nienheuser <earthwings@gentoo.org>
Thanks for the patch!

CCMAIL: earthwings@gentoo.org
BUG: 150371


 M  +31 -13    identitystatuswidget.cpp  
 M  +1 -0      identitystatuswidget.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=720777

Comment 3 Dennis Nienhüser 2007-10-09 00:01:06 UTC

Created attachment 21775 [details]
identitystatuswidget_2.cpp.diff

It didn't yet update when accounts were added or removed, this patch connects
the appropriate signal and updates the widget height as well.

Comment 4 Dennis Nienhüser 2007-10-09 00:01:46 UTC

Reopening as per comment #3

Comment 5 Dennis Nienhüser 2007-10-11 23:20:52 UTC

r724268 | nienhueser | 2007-10-11 23:12:43 +0200 (Do, 11 Okt 2007) | 3 lines

Update identity widget if accounts are added or removed, and make sure widget height is set properly
BUG: 150371

Permissions to close this from SVN not working yet, but the patch is in.