Bug 150307

Summary:	Allow symlinks in standard dirs (eg. looking for services)
Product:	[Unmaintained] kdelibs	Reporter:	P.Christeas <p_christ>
Component:	general	Assignee:	kdelibs bugs <kdelibs-bugs>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	ats-kdebugs, coolo, fbelew
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Follow symlinks in kstandarddirs Previous patch + menu vfolder symlink patch

Description P.Christeas 2007-09-28 20:27:41 UTC

Version:           3.93 (using KDE Devel)
Installed from:    Compiled sources
OS:                Linux

KBuildSycoca only scans real dirs/files. If any service/app etc. is a symlink, it will be silently ignored.
Actually, its importance is minor: devels, who regularly update those files, may instead want to store them elsewhere and symlink to service dirs.

The attached patch will also scan inside symlinks.

Comment 1 P.Christeas 2007-09-28 20:29:03 UTC

Created attachment 21708 [details]
Follow symlinks in kstandarddirs

Comment 2 David Faure 2007-09-28 21:07:19 UTC

One problem might be infinite recursions due to symlinks to ".."

Comment 3 P.Christeas 2007-09-28 22:19:08 UTC

DFaure: It may be not: as long as the fn's are fed with the initial path (and not the resolved symlink), the system will prevent too many symlinks. 
See errno: ELOOP  "Too many symbolic links were encountered in resolving pathname.."

Comment 4 frb 2008-02-07 22:25:22 UTC

Created attachment 23468 [details]
Previous patch + menu vfolder symlink patch

The previous patch allowed services to be found and plasma to load. This patch
uses that, and allows menus to load in kickoff.

I don't think this is the complete patch yet. I'm still having issues with
protocol handlers.

Comment 5 David Faure 2008-03-26 12:19:55 UTC

*** Bug 159861 has been marked as a duplicate of this bug. ***

Comment 6 David Faure 2008-03-26 12:23:33 UTC

SVN commit 790285 by dfaure:

Fix broken handling of symlinks because of the d_type optimization
BUG: 150307


 M  +2 -2      kdecore/kernel/kstandarddirs.cpp  
 M  +2 -2      kded/vfolder_menu.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=790285

Comment 7 Lubos Lunak 2008-05-21 16:40:25 UTC

*** Bug 157287 has been marked as a duplicate of this bug. ***