Bug 150259

Matija,

Are you sure ?

Look like Gwenview use this sentence :

http://websvn.kde.org/branches/extragear/kde3/graphics/gwenview/desktopfiles/gwenview.desktop?revision=676988&view=markup

More info about desktop file : 

http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#mime-types

Gilles Caulier

Hey, Gilles.

I don't know for sure, but I use desktop-file-utils on Gentoo, so each time I emerge a package it runs the check. What I posted is the a copy-paste of what I got after an emerge.

I use the 0.14 version of desktop-file-utils and portage (Gentoo's "package" management) it used the sources from:
http://www.freedesktop.org/software/desktop-file-utils

Achim, 

What do you think about ? It's a valid report for Debian packaging ?

Gilles Caulier

It's valid but not a big deal.  I remember S. Binner fixing dozend of MimeType in desktop adding final ';'.  AFAIU the mimetypes are neverthelss accepted, but this may/can change in the future.  So it should be fixed in SVN at least.

Achim

E.g.:
SVN commit 678559 by binner:

fix invalid .desktop files


 M  +1 -1      kfaxview/kfaxview.desktop  
 M  +1 -1      kghostview/kghostview.desktop  
 M  +1 -1      kolourpaint/kolourpaint.desktop  
 M  +1 -1      kpdf/shell/kpdf.desktop  
 M  +1 -1      kuickshow/src/kuickshow.desktop  
 M  +1 -1      kview/kview.desktop  


--- branches/KDE/3.5/kdegraphics/kfaxview/kfaxview.desktop #678558:678559
@@ -67,7 +67,7 @@
 Name[ne]=केडीई फ्याक्स दृश्य
 Name[sv]=Kfaxview
 Name[zh_TW]=KFaxView 傳真檢視
-MimeType=image/fax-g3
+MimeType=image/fax-g3;
 InitialPreference=6
 Exec=kfaxview %f
 Icon=kfaxview
--- branches/KDE/3.5/kdegraphics/kghostview/kghostview.desktop #678558:678559
@@ -12,7 +12,7 @@
 Name[tr]=GhostView
 Name[ven]=Mbonalelo ya tshipuku tsha K
 Name[xh]=Imboniselo yeKGhost
-MimeType=application/pdf;application/postscript;image/x-eps;application/x-gzpostscript;application/illustrator
+MimeType=application/pdf;application/postscript;image/x-eps;application/x-gzpostscript;application/illustrator;
 InitialPreference=6
 Exec=kghostview %u -caption "%c" %i %m
 Icon=kghostview
--- branches/KDE/3.5/kdegraphics/kolourpaint/kolourpaint.desktop #678558:678559
@@ -83,7 +83,7 @@
 # SYNC: Run branches/kolourpaint/control/scripts/gen_mimetype_line.sh in
 #       the version of kdelibs/kimgio/ (e.g. KDE 3.5) KolourPaint is
 #       shipped with.
-MimeType=image/fax-g3;image/gif;image/jp2;image/jpeg;image/png;image/tiff;image/x-bmp;image/x-dds;image/x-eps;image/x-exr;image/x-hdr;image/x-ico;image/x-pcx;image/x-portable-bitmap;image/x-portable-greymap;image/x-portable-pixmap;image/x-rgb;image/x-targa;image/x-vnd.adobe.photoshop;image/x-xbm;image/x-xcf-gimp;image/x-xpm;video/x-mng
+MimeType=image/fax-g3;image/gif;image/jp2;image/jpeg;image/png;image/tiff;image/x-bmp;image/x-dds;image/x-eps;image/x-exr;image/x-hdr;image/x-ico;image/x-pcx;image/x-portable-bitmap;image/x-portable-greymap;image/x-portable-pixmap;image/x-rgb;image/x-targa;image/x-vnd.adobe.photoshop;image/x-xbm;image/x-xcf-gimp;image/x-xpm;video/x-mng;
 
 Categories=Qt;KDE;Graphics;
 Terminal=false
--- branches/KDE/3.5/kdegraphics/kpdf/shell/kpdf.desktop #678558:678559
@@ -1,6 +1,6 @@
 [Desktop Entry]
 Encoding=UTF-8
-MimeType=application/pdf
+MimeType=application/pdf;
 Terminal=false
 Name=KPDF
 Name[ar]=برنامج KPDF
--- branches/KDE/3.5/kdegraphics/kuickshow/src/kuickshow.desktop #678558:678559
@@ -18,7 +18,7 @@
 Exec=kuickshow %i %m -caption "%c" %U
 Icon=kuickshow
 Type=Application
-MimeType=image/gif;image/x-xpm;image/x-xbm;image/jpeg;image/png;image/tiff;image/x-bmp;image/x-psd;image/x-eim;image/x-portable-bitmap;image/x-portable-pixmap;image/x-portable-greymap
+MimeType=image/gif;image/x-xpm;image/x-xbm;image/jpeg;image/png;image/tiff;image/x-bmp;image/x-psd;image/x-eim;image/x-portable-bitmap;image/x-portable-pixmap;image/x-portable-greymap;
 DocPath=kuickshow/index.html
 Terminal=false
 InitialPreference=6
--- branches/KDE/3.5/kdegraphics/kview/kview.desktop #678558:678559
@@ -72,7 +72,7 @@
 GenericName[zh_HK]=圖像檢視器
 GenericName[zh_TW]=影像檢視程式
 GenericName[zu]=Umbonisi Womfanekiso
-MimeType=image/gif;image/x-xpm;image/x-xbm;image/jpeg;image/x-bmp;image/png;image/x-ico;image/x-portable-bitmap;image/x-portable-pixmap;image/x-portable-greymap;image/tiff;image/jp2
+MimeType=image/gif;image/x-xpm;image/x-xbm;image/jpeg;image/x-bmp;image/png;image/x-ico;image/x-portable-bitmap;image/x-portable-pixmap;image/x-portable-greymap;image/tiff;image/jp2;
 Name=KView
 Name[af]=K-bekyk
 Name[ar]=برنامج KView

Achim,

ok, can you fix accordingly KDE3 and KDE4 desktop files, and check if all is fine with packaging as well ?

Thanks in advance

Gilles Caulier

Achim,

I'm too stupid (:=)). File is already patched by this commit :

http://websvn.kde.org/trunk/extragear/graphics/digikam/showfoto/showfoto.desktop?r1=675278&r2=724741

I close this file now

Gilles Caulier