| Summary: | fullscreen icon changes image's zoom to 100% (should fit to screen) | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Nadav Kavalerchik <nadavkav> |
| Component: | Preview-Image | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | toralf.foerster |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 0.9.4 | |
| Sentry Crash Report: | |||
| Attachments: |
patch #1
Another fix |
||
|
Description
Nadav Kavalerchik
2007-09-08 14:46:35 UTC
Nadav, Full screen from album gui or image editor ? Gilles caulier album gui On 8 Sep 2007 15:00:55 -0000, Gilles Caulier <caulier.gilles@gmail.com> wrote: [bugs.kde.org quoted mail] album gui<br><br><br><div><span class="gmail_quote">On 8 Sep 2007 15:00:55 -0000, <b class="gmail_sendername">Gilles Caulier</b> <<a href="mailto:caulier.gilles@gmail.com">caulier.gilles@gmail.com</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> ------- You are receiving this mail because: -------<br>You reported the bug, or are watching the reporter.<br><br><a href="http://bugs.kde.org/show_bug.cgi?id=149654">http://bugs.kde.org/show_bug.cgi?id=149654</a><br><br> <br><br><br>------- Additional Comments From caulier.gilles gmail com 2007-09-08 17:00 -------<br>Nadav,<br><br>Full screen from album gui or image editor ?<br><br>Gilles caulier<br></blockquote></div><br> and... after the image's thumb was pressed. because if you don't click the image's thumb and just move to Full Screen Mode and then click any image thumb then all is ok. On 8 Sep 2007 15:00:55 -0000, Gilles Caulier <caulier.gilles@gmail.com> wrote: [bugs.kde.org quoted mail] and...<br>after the image's thumb was pressed.<br>because if you don't click the image's thumb and just move to Full Screen Mode and then click any image thumb then all is ok.<br><br><div><span class="gmail_quote"> On 8 Sep 2007 15:00:55 -0000, <b class="gmail_sendername">Gilles Caulier</b> <<a href="mailto:caulier.gilles@gmail.com">caulier.gilles@gmail.com</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> ------- You are receiving this mail because: -------<br>You reported the bug, or are watching the reporter.<br><br><a href="http://bugs.kde.org/show_bug.cgi?id=149654">http://bugs.kde.org/show_bug.cgi?id=149654</a><br><br> <br><br><br>------- Additional Comments From caulier.gilles gmail com 2007-09-08 17:00 -------<br>Nadav,<br><br>Full screen from album gui or image editor ?<br><br>Gilles caulier<br></blockquote></div><br> sorry for the gmail garbedge I can confirm this bug... it doesn't seem to be fixed in 0.9.4beta4. Wouldn't it be even better, if the current zoom-level and center position is kept ? I.e.: if fit-to-window is the current view, then also do a fit-to-window in full-screen mode. But if a different zoom (eg. 100% etc.) and centering is done, this should be kept. Arnd, yes I think it should keep the current settings, but right now it is not working as expected. If you have "fit-to-window" enabled, click on a thumbnail to open the image viewer and click on the fullscreen icon, the image is displayed in its full size (1:1). You have to return into thumbnail view mode and click on the image again to have it "fit-to-window". So when switching into fullscreen mode while looking at an image you have to click the mouse 3 times (fullscreen icon, image->thumbnail view, image->image view) to get the result you expect. Created attachment 25453 [details]
patch #1
After testing millions of signals and slots I found a solution that works...
Another solution was setting an additional fit2window boolean variable and
calling 4 signals, but in the end this seems to be much easier and the
displaying is much faster.
Gilles, what do you think?
Created attachment 25615 [details]
Another fix
It's caused by slotZoomSliderChanged(d->albumSettings->getDefaultIconSize()) in
DigikamApp::show() which is called when switching to fullscreen.
slotZoomSliderChanged(d->albumSettings->getDefaultIconSize()) sets the
zoomFactor to a value larger than calcAutoZoomFactor(ZoomInOnly), and hence
ImagePreviewView::resizeEvent(...) does not set the fit-to-window zoom factor.
I simply removed slotZoomSliderChanged(d->albumSettings->getDefaultIconSize())
(see attachment).
Andi, Please look fix from Gerhard. We will take a look together whole changes before inclusion in svn... Gilles Seems to work fine... SVN commit 827143 by aclemens: fixed image resize issue when switching to fullscreen mode BUG:149654 M +2 -1 NEWS M +0 -3 digikam/digikamapp.cpp M +1 -1 digikam/digikamappprivate.h WebSVN link: http://websvn.kde.org/?view=rev&revision=827143 *** Bug 159788 has been marked as a duplicate of this bug. *** |