Bug 149589

Summary:	JJ: Right click on "task complete" box should not tick/untick box
Product:	[Applications] ktimetracker	Reporter:	Reuben Thomas <rrt>
Component:	general	Assignee:	Thorsten Staerk <dev>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	LO
Version:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Left click only completion

Description Reuben Thomas 2007-09-06 02:15:24 UTC

Version:           1.6.0 (using KDE 3.5.7, Debian Package 4:3.5.7.dfsg.1-4 (lenny/sid))
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.21-2-686

Right-clicking should not change the status of something in the window, including the task complete tick-box.

Comment 1 Thorsten Staerk 2007-09-06 13:53:04 UTC

This is a junior job (JJ).

Comment 2 Luca Bedogni 2007-09-10 13:20:39 UTC

Created attachment 21585 [details]
Left click only completion

This is a (proposed) patch to fix this bug.
Since it's my first kde patch, I hope I did everything ok. If not, please let
me know.

Comment 3 Thorsten Staerk 2007-09-10 22:48:08 UTC

looks correct!

Comment 4 Thorsten Staerk 2007-09-10 22:55:36 UTC

SVN commit 710766 by tstaerk:

Do not set completed flag when clicking with the right mouse button.
BUGS: 149589


 M  +3 -2      taskview.cpp  


--- branches/KDE/3.5/kdepim/karm/taskview.cpp #710765:710766
@@ -131,8 +131,9 @@
     int leftborder = treeStepSize() * ( task->depth() + ( rootIsDecorated() ? 1 : 0)) + itemMargin();
     if ((leftborder < e->x()) && (e->x() < 19 + leftborder ))
     {
-      if ( task->isComplete() ) task->setPercentComplete( 0, _storage );
-      else task->setPercentComplete( 100, _storage );
+      if ( e->button() == LeftButton )
+        if ( task->isComplete() ) task->setPercentComplete( 0, _storage );
+        else task->setPercentComplete( 100, _storage );
     }
     emit updateButtons();
   }