| Summary: | KTimeTracker: Marking task done does not stop the time (includes patch) | ||
|---|---|---|---|
| Product: | [Applications] ktimetracker | Reporter: | Christian Mandery <kdebugzilla> |
| Component: | general | Assignee: | Thorsten Staerk <dev> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nicu |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
confirmed, this is a bug. SVN commit 705768 by tstaerk:
Do not track a complete task. Applying patch by Christian Mandery.
CCBUGS:149302
M +1 -0 taskview.cpp
--- trunk/KDE/kdepim/ktimetracker/taskview.cpp #705767:705768
@@ -388,6 +388,7 @@
if (task->isComplete()) {
task->setPercentComplete( 0, d->mStorage );
} else {
+ stopTimerFor( task ); // Use our own method instead of calling setRunning() directly
task->setPercentComplete( 100, d->mStorage );
}
SVN commit 705813 by tstaerk:
backport 705768
CCBUGS:149302
M +1 -1 task.cpp
--- branches/KDE/3.5/kdepim/karm/task.cpp #705812:705813
@@ -160,7 +160,7 @@
else
_percentcomplete = percent;
- if (isRunning() && _percentcomplete==100) setRunning(false, storage);
+ if (isRunning() && _percentcomplete==100) taskView()->stopTimerFor(this);
setPixmapProgress();
SVN commit 705814 by tstaerk:
Do not track a task that has been marked as complete in no matter what
way.
BUGS:149302
M +1 -1 task.cpp
M +0 -1 taskview.cpp
--- trunk/KDE/kdepim/ktimetracker/task.cpp #705813:705814
@@ -242,7 +242,7 @@
else
d->mPercentComplete = percent;
- if (isRunning() && d->mPercentComplete==100) setRunning(false, storage);
+ if (isRunning() && d->mPercentComplete==100) taskView()->stopTimerFor(this);
setPixmapProgress();
--- trunk/KDE/kdepim/ktimetracker/taskview.cpp #705813:705814
@@ -388,7 +388,6 @@
if (task->isComplete()) {
task->setPercentComplete( 0, d->mStorage );
} else {
- stopTimerFor( task ); // Use our own method instead of calling setRunning() directly
task->setPercentComplete( 100, d->mStorage );
}
*** Bug 143724 has been marked as a duplicate of this bug. *** |
Version: (using KDE Devel) Installed from: Compiled sources Setup: - Create task - Start task - Task runs - Mark task done by clicking the box - Task is now marked 100% complete but keeps running Please apply my simple patch that should fix the problem: --- taskview.cpp 2007-08-28 14:41:30.000000000 +0200 +++ taskview.cpp.new 2007-08-28 14:41:26.000000000 +0200 @@ -386,6 +386,7 @@ if (task->isComplete()) { task->setPercentComplete( 0, d->mStorage ); } else { + stopTimerFor( task ); // Use our own method instead of calling setRunning() directly task->setPercentComplete( 100, d->mStorage ); }