Bug 148930

Summary: digikam-0.9.2 does not compile with lcms-1.17
Product: [Applications] digikam Reporter: Ingmar Vanhassel <ingmar>
Component: Portability-CompilationAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: anaselli, caulier.gilles, rdieter
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Gentoo Packages   
OS: Linux   
Latest Commit: Version Fixed In: 0.9.3
Sentry Crash Report:
Attachments: digikam-0.9.2 build log
patch to solve the problem

Description Ingmar Vanhassel 2007-08-17 15:12:35 UTC 
Version:           0.9.2 (using KDE KDE 3.5.7)
Installed from:    Gentoo Packages
Compiler:          gnu-gcc 4.2.0 
OS:                Linux

Digikam fails to compile with a version of lcms > 1.16.

snippet from the Changelog for lcms-1.17:

 New in ver 1.17
 ===============

Changes in API
----------------------

WIN64 support
_vsnprintf wrap
BOOL replaced by LCMSBOOL
cmsSetLanguage parameters changed to match ICC spec
removed support for extended gamut descriptor (was never fully implemented)
cmsFLAGS_NODEFAULTRESOURCEDEF moved to 0x01000000
_cmsMalloc wrapper for malloc
_cmsFree wrapper for free
Comment 1 Ingmar Vanhassel 2007-08-17 15:22:28 UTC 
Created attachment 21421 [details]
digikam-0.9.2 build log

Attaching build log, showing compiler output.
Comment 2 Angelo Naselli 2007-08-22 00:22:22 UTC 
Created attachment 21446 [details]
patch to solve the problem

this simple patch fixes the problem and keeps the compatibility with old 1.16
version. That could be helpful to keep old version testers, and to give
packager the availability to backport fixings.
Comment 3 caulier.gilles 2007-08-22 08:00:16 UTC 
Thanks for the patch Angello. I will test today...

Gilles
Comment 4 caulier.gilles 2007-08-22 08:12:44 UTC 
SVN commit 703177 by cgilles:

digiKam from trunk (KDE4): patch from Angelo Naselli about to compile digiKam with lcms 1.17. Tested under Mandriva 2008.0 (cooker)
CCBUGS: 148930


 M  +4 -0      lcmsprf.h  


--- trunk/extragear/graphics/digikam/libs/lprof/lcmsprf.h #703176:703177
@@ -68,6 +68,10 @@
 
     } MATN,FAR* LPMATN;
 
+// See B.K.O #148930: compile with lcms v.1.17
+#if (LCMS_VERSION > 116)
+typedef LCMSBOOL BOOL;
+#endif
 
 LPMATN      cdecl MATNalloc(int Rows, int Cols);
 void        cdecl MATNfree (LPMATN mat);
Comment 5 caulier.gilles 2007-08-22 09:03:13 UTC 
SVN commit 703199 by cgilles:

digiKam from KDE3 branch : patch from Angelo Naselli about to compile digiKam with lcms 1.17. Tested under Mandriva 2007.1 and 2008.0 (cooker)
BUG: 148930


 M  +4 -0      lcmsprf.h  


--- branches/extragear/kde3/graphics/digikam/libs/lprof/lcmsprf.h #703198:703199
@@ -69,6 +69,10 @@
 
     } MATN,FAR* LPMATN;
 
+// See B.K.O #148930: compile with lcms v.1.17
+#if (LCMS_VERSION > 116)
+typedef LCMSBOOL BOOL;
+#endif
 
 LPMATN      cdecl MATNalloc(int Rows, int Cols);
 void        cdecl MATNfree (LPMATN mat);