Bug 148659

Summary:	[PATCH] History Search does not work propertly
Product:	[Unmaintained] kopete	Reporter:	Uniqus <uniqus>
Component:	History Plugin	Assignee:	Kopete Developers <kopete-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	schwarzer, Simon80
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	kopetehistory.patch kopetehistory.patch kopetehistory-kde4.patch

Description Uniqus 2007-08-09 01:38:33 UTC

Version:           0.12.5 (using KDE 3.5.7, Kubuntu (feisty) 4:3.5.7-0ubuntu1~feisty2)
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.20-16-generic

When I am trying to use Search in some of my contacts' history, I get unpredictable results: the progress bar moves, something seems to be happening, but at the end, with some keywords search gives me some results, with some other ones I get no results at all, even if I provide a keyword which I just can see in the history with my eyes without any search. And I just cannot find out any regularity in this behavior: keywords for which search fails are very different, starting from "hello" and ending with something like "public_html" or "FTP".
This is really sad, because I like Kopete, but I have to use another IM client since ability to search in the history is the critical feature for me.
And another one thing about history: it is VERY slow. Especially Search in history, which in addition in most cases does not give me what I am looking for.
If you at least can fix the bug with search until the next release, I will be happy to migrate back to Kopete.
Thanks.

Comment 1 Charles Connell 2007-08-30 20:05:53 UTC

There are plans to use Strigi for a better searching mechanism for History. Probably in Kopete 1.0, with KDE 4.1

Comment 2 Simon80 2007-10-23 07:48:53 UTC

Created attachment 21899 [details]
kopetehistory.patch

This patch fixes the reason why search was slow, along with fixing Bug 143549
and Bug 141566.

Comment 3 Simon80 2007-10-23 08:21:52 UTC

Created attachment 21900 [details]
kopetehistory.patch

This is a one line fix to the last patch, to initialise a bool before using it.

Comment 4 Matt Rogers 2008-07-06 06:00:36 UTC

The patch provided doesn't apply cleanly to svn trunk. Can you make a new one?

Comment 5 Simon80 2008-07-06 19:59:14 UTC

I've made a patch that applies to trunk as well as to recent releases of kopete, I'm testing it with the Ubuntu 8.04 source package of kdenetwork-kde4. When that has built and I've run it briefly, I'll attach it.

I'd also appreciate it if the old patch were applied to the tip of the KDE 3 branch, in case there are more releases of that. When kopete 0.12.4 came out, it bothered me that the patch hadn't been applied, considering the effort it took to make, and how much it improved the search function.

Comment 6 Matt Rogers 2008-07-06 22:22:39 UTC

SVN commit 828859 by mattr:

Fix slowness in history searching for KDE 3.5

Thanks for the patch! Sorry to take so long with it.
Looking forward to the one for KDE 4.0 so we can close
this for real.

CCBUG: 148659



 M  +76 -106   historydialog.cpp  
 M  +1 -18     historydialog.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=828859

Comment 7 Simon80 2008-07-07 02:32:23 UTC

Created attachment 25890 [details]
kopetehistory-kde4.patch

I've successfully tested my patch with Kopete 0.50.1, KDE 4.0.5, as mentioned
above, from http://packages.ubuntu.com/source/hardy/kdenetwork-kde4

It looks like adding search results to the list on the left may be a
bottleneck, because the speed decreases as the number of search results
increases.

The speedup doesn't seem as pronounced as it was in KDE 3, so it might not be
clear whether the patch is being used. Two tells with the old code are that the
Search button's mnemonic shortcut changes, and if you hit cancel, the code
fails to unhide all of the elements in the left pane.

Comment 8 Simon80 2008-08-03 06:29:10 UTC

Hi, has this bug been forgotten?

Comment 9 Frederik Schwarzer 2008-12-26 15:54:06 UTC

Is there any update on this one?

Comment 10 Matt Rogers 2009-01-30 18:10:57 UTC

SVN commit 918744 by mattr:

Port history search speedup from KDE 3.5

Sorry for taking so long with this. Thanks for your patch!

BUG: 148659
CCMAIL: simon80@gmail.com

 M  +65 -76    historydialog.cpp  
 M  +1 -16     historydialog.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=918744