Bug 148198

Hi Bernhard,

while I am able to understand the first part of your statement,
I have problems with the second part (After "So ...").
Though I have some guesses ;-), could you please explain in more detail?

Thanks, Arnd

I think of something like iTunes and Amarok do.
p.e.
When I look at the Thumbnailview, I can show the image rating below the Image, but I'm not able to change it, i have to click the image and go to the right panel and click on the rating to change it.
So why not use the "Rating Bar" from the right Panel directly in the Thumbnailview.
Just go to video.google.com and watch a clip, there is a rating functionality which does what I mean in the upper left corner while watching.


Did you understand what I mean?
I'm currently at the office, I will try to explain more detailed at home.

Bernhard,

Sound like to superimpose the widget on right side bar over the thumbs to rate images.

I think it's more easy to do it with QT4/KDE4 (place the current rating widget over the icon item). 

Marcel, what do you think about ?

Gilles

> I think it's more easy to do it with QT4/KDE4 (place the current rating
> widget over the icon item).


And mini icons for rotating :)

Like in 
http://www.youtube.com/watch?v=rk2-uIE3nCg
really would be nice

I presently have modem access only, so I can't watch it.
Now I do understand your wish and it makes perfect sense
(together with the suggestion of Mikolaj and maybe a mini-globe
icon to indicate GPS coordinates - but that would be a separate
wish ;-)

Just for completeness: you are aware of CTRL-1 to CTRL-5
shortcut to set the rating of the selected image(s).

I'm aware of the shortcuts, but the normal user wants to use his mouse for most of the time.

I've heard from the Amarok Devs, that say want to use Plasma Widgets for some of their GUI parts.

http://amarok.kde.org/wiki/CoverBling_overview

What do you think about that?
Or should that be posted under another topic?

Plasma is QGraphicsView + a layer to make things easier. We can evaluate QGraphicsView - with no predetermined result as to use it or not - but only after everything has settled down and stabilized in the porting.

Ok I understand that point, but I think the idea is great because of reusable elements (p.e. amaroks new cover flow...) so you should leave in your head. btw. look how the amarok guys deal with it.

Another candidate for Qt4 model/view port of albumiconview

Gilles Caulier

Created attachment 29982 [details]
rating icon view item on the fly

I'm currently working on this file.

Patch is not yet finalized, but it's ready to be tested.

It only patch Iconview. in the future, i will do thumbbar item too...

Marcel, Andi,

For me, this will be the last feature to add with Qt3support classes. All future developments on iconview/thumbbar need to use Qt4 Model/view

Best

Gilles Caulier

Seems to work fine, only negative point (at least here with KDE 4.2) is that the rating widget moves like 10 pixels up when you hover over with the mouse, so that vertically thumbnails get partly hidden by the rating widget.

Created attachment 29993 [details]
rating icon view item on the fly version 2

New version ready to commit. several improvement and polish have been done.

Some factoring of code still todo.

Please test

Gilles

Works fine...

one liiiitlllle (:-)) refinement can be done when hovering over the rating widget:

1. set rating of an image to 5
2. hover over the widget
3. it moves like 3 pixels to the left

But this is really a tiny detail, so I think committing will be ok.

Andi

SVN commit 906970 by cgilles:

digiKam from trunk: add support to rating icon view item on the fly.
BUG: 148198


 M  +1 -0      CMakeLists.txt  
 M  +25 -7     digikam/albumiconitem.cpp  
 M  +4 -0      digikam/albumiconitem.h  
 M  +44 -6     digikam/albumiconview.cpp  
 M  +3 -1      digikam/albumiconview.h  
 M  +28 -1     digikam/iconitem.cpp  
 M  +8 -1      digikam/iconitem.h  
 M  +95 -0     digikam/iconview.cpp  
 M  +7 -1      digikam/iconview.h  
 AM            digikam/ratingbox.cpp   [License: GPL (v2+)]
 AM            digikam/ratingbox.h   [License: GPL (v2+)]


WebSVN link: http://websvn.kde.org/?view=rev&revision=906970

Thanks Gilles, such small feature and how much pleasure :)

One thought: with this addition Assign Rating position in context menu becomes redundant, maybe remove this?

ps. Confirming what Andi writes about moving stars. Looks like problem with centering - assigned stars are centered differently from assigning widget; you can also see this when rating with one star. When hovering to display whole widget lonely star should become central outlined star - instead there is small movement left.

>One thought: with this addition Assign Rating position in context menu becomes >redundant, maybe remove this? 

yes. Rating on icon view item can be disable.

Also, with context menu you can rate more than one item at the same time.

>Looks like problem with centering

Yes, i will fix it.

Gilles

SVN commit 907726 by cgilles:

digiKam from trunk: it now possible to rate item from tumbbar, as with icon view
CCBUG: 148198


 M  +183 -21   digikam/imagepreviewbar.cpp  
 M  +12 -0     digikam/imagepreviewbar.h  
 M  +28 -21    libs/widgets/common/thumbbar.cpp  
 M  +5 -4      libs/widgets/common/thumbbar.h  
 M  +17 -11    project/project.kdevelop  
 M  +20 -14    utilities/lighttable/lighttablebar.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=907726

Please add a switch to disable this feature - it can easily be activated by accident.

ATM it is only possible to deactivate  "show rating" in the thumbnail completely.

(And this, for some strange reasons, will also deactivate the rating widget in the status bar filter?! (see #181705)