Bug 148128

Summary:	Compile error on Solaris 8 - kdenetwork/kget/ui/droptarget.cpp uses fabsf which is not available
Product:	[Applications] kget	Reporter:	Steve Evans <stevee>
Component:	general	Assignee:	KGet bugs <kget-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Solaris
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Steve Evans 2007-07-23 08:44:47 UTC

Version:            (using KDE Devel)
Installed from:    Compiled sources
Compiler:          gcc 3.4.6 
OS:                Solaris

I get this compile error on Solaris:

[  3%] Building CXX object kget/CMakeFiles/kget.dir/ui/droptarget.o
/cad4/stevee/kde-svn/kdenetwork/kget/ui/droptarget.cpp: In member function `void DropTarget::slotAnimateShow()':
/cad4/stevee/kde-svn/kdenetwork/kget/ui/droptarget.cpp:325: error: `fabsf' was not declared in this scope
/usr/ccs/bin/as: "<stdin>", line 1045: error: symbol "_ZN10DropTargetD1Ev" is used but not defined
/usr/ccs/bin/as: "<stdin>", line 1045: error: symbol "_ZN10DropTargetD0Ev" is used but not defined
/usr/ccs/bin/as: "<stdin>": , approx line 1045: internal error: evaluate_symbol_expression(): op 20?

Replacing the two uses of fabsf with the more portable fabs fixes the problem

Comment 1 Urs Wolfer 2007-07-23 19:49:06 UTC

SVN commit 691467 by uwolfer:

Use the portable fabs instead of fabsf. Fixes build problem on solaris.
BUG: 148128

 M  +1 -1      droptarget.cpp  


--- trunk/KDE/kdenetwork/kget/ui/droptarget.cpp #691466:691467
@@ -322,7 +322,7 @@
 
     move(x(), (int)(position.y() * (1 + ani_y)));
 
-    if ( fabsf(ani_y) < 0.01 && fabsf(ani_vy) < 0.01 && animTimer )
+    if ( fabs(ani_y) < 0.01 && fabs(ani_vy) < 0.01 && animTimer )
     {
         animTimer->stop();
         delete animTimer;