Bug 148021

Summary:	kdelibs: build fails against cups-1.3
Product:	[Unmaintained] kdeprint	Reporter:	Rex Dieter <rdieter>
Component:	general	Assignee:	KDEPrint Devel Mailinglist <kde-print-devel>
Status:	CLOSED FIXED
Severity:	normal	CC:	jlayt
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Fedora RPMs
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	use new cups_server access methods, compatible with cups-1.3 +cups-1.3 compatibility

Description Rex Dieter 2007-07-19 14:02:45 UTC

Version:            (using KDE KDE 3.5.7)
Installed from:    Fedora RPMs
Compiler:          gcc version 4.1.2 20070502 (Red Hat 4.1.2-12) 
OS:                Linux

kdeprint/cups/cupsdconf2/cups-util.c
uses a deprecated api to access fields within the cups-server structure, which has been removed in cups-1.3.

Patch forthcoming.

Comment 1 Rex Dieter 2007-07-19 14:04:46 UTC

Created attachment 21186 [details]
use new cups_server access methods, compatible with cups-1.3

Comment 2 Cristian Tibirna 2007-07-19 14:24:16 UTC

Thanks a lot for this. Did you happen to investigate at what version of CUPS 
the new API was introduced? I will look myself as soon as I get some time.

Depending on this, we might need to use a version-defined macro, that will be 
translated either to the old call or the new call that you present here,  so 
that we can still compile with older CUPS versions.

Thanks. I will take a look.

Comment 3 Rex Dieter 2007-07-19 14:31:12 UTC

The patch appears to be incomplete (ie, doesn't fix all cups-1.3 issues).

I was assured by our cups maintainer that this is compatible with cups-1.2 at least.

Comment 4 Rex Dieter 2007-07-19 16:08:26 UTC

See also downstream bug:
http://bugzilla.redhat.com/248717

Comment 5 Alex Merry 2007-07-19 23:23:23 UTC

That code's all being ripped out on Monday, when I up the minimum CUPS version to 1.1.20.

The code in question is compatibility code copied out of CUPS itself, implementing functions available in CUPS 1.1.20.

Comment 6 Alex Merry 2007-07-19 23:24:47 UTC

To make it clear: only the functions cupsGetConf() and cupsPutConf() will remain in that file after Monday.

Comment 7 Rex Dieter 2007-07-20 13:57:36 UTC

Regardless, I'll attach a stop-gap patch for kde-3.5.7.

Comment 8 Rex Dieter 2007-07-20 13:58:29 UTC

Created attachment 21204 [details]
+cups-1.3 compatibility

Comment 9 Kurt Pfeifle 2007-07-27 00:02:11 UTC

Be aware that CUPS 1.3 is not yet final.

There's only the first Beta out currently. There may still be some changes in the pipeline for the final 1.3.0.

Comment 10 Pino Toscano 2007-12-11 17:34:42 UTC

Wasn't a CUPS 1.3 support committed in both kdeprint 3.5 and 4.0, already?

Comment 11 Rex Dieter 2007-12-19 00:21:24 UTC

yes, confirmed fixed in latest releases.  (thanks).

Comment 12 John Layt 2008-12-31 20:55:25 UTC

Closing old Resolved status bug.