Summary: | Typos in the digiKam KDE3 PO file | ||
---|---|---|---|
Product: | [Applications] digikam | Reporter: | Clytie Siddall <clytie> |
Component: | Usability-i18n | Assignee: | Digikam Developers <digikam-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | caulier.gilles, kde |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Other | ||
Latest Commit: | Version Fixed In: | 0.9.4 | |
Sentry Crash Report: | |||
Attachments: | Patch for all issues but one (see my comment). |
Description
Clytie Siddall
2007-07-06 08:03:08 UTC
Thanks Clytie, This is a non-developper task (:=))). This is important to fix these strings in KDE3 _and_ KDE4 branches (KDE3 in priority because we will release 0.9.3 to update i18n translations) Who want do it ? Thanks in advance... Gilles Caulier PS: Clytie, it will be better to provide a real patch in the future. It's will more simple/faster to apply it on svn. Make a patch is really simple with svn if you now how are embedded string in source code... Gilles, I will prepare a patch later today. These small contributions are unfortunately all I have time for right now (diploma exams and thesis finishing time). Frank Sorry, I don't know how to create a patch for the code. This is the best I can do, due to brain damage. If there is a simple way to create a patch for a PO file, please tell me, but it has to be simple, unfortunately. Clytie, The patch must be done with source code, not .po files. .po files are created from source code using gettext by a script working on KDE servers. All strings are annoted using i18n("...") in source code. You just need to grep your strings, edit .cpp source file and make a patch using "svn diff" command Gilles Some more details: To find the right file one option is to use the command find -name "*.cpp" -type f -exec grep "Already assigned" {} /dev/null \; This restricts the search to all *.cpp files and finds the string "Already assigned" recursively from the current directory. So if you have a svn checkout of the code, you could start from the `graphics/digikam directory. The matching files and the corresponding line will be shown. For the example above I get ./libs/imageproperties/imagedescedittab.cpp: QToolTip::add(d->assignedTagsBtn, i18n("Already assigned tags")); Then you could call `emacs ./libs/imageproperties/imagedescedittab.cpp &` (or whatever your preferred editor is ;-), go to that line and change it. Finally, to create a patch file with all changes, the command is svn diff > text_changes.patch Hope I got it all right, and that it helps - please don't hesitate to ask. Anyway, this round Frank will take care of the changes (thanks!). Best, Arnd Created attachment 21071 [details]
Patch for all issues but one (see my comment).
(Note: I just see, that Gilles and Arnd already explained ways to go. But here is what I just wrote, just in case it suits you better.) Ok, here is the patch. Clytie, that is a really really long list, and must have taken quite long to create. Do you think it would be easier for you to fix these strings directly in digiKam's SVN and make a patch out of that? That might be easier than describing the changes in the thorough manner as you did. The easiest way might be the following: 0. Checkout digikam from SVN (kde3 and/or trunk): svn co svn://anonsvn.kde.org/home/kde/branches/extragear/kde3/graphics/digikam svn co svn://anonsvn.kde.org/home/kde/trunk/extragear/graphics/digikam 1. Find the affected file(s) for a certain string "SearchedString": cd digikam grep "SearchedString" $(find . -name "*.cpp" -o -name "*.h" -o -name "*.ui") | cut -d":" -f1 | uniq 1.a Instead, if you want, you can automatically open these files in an editor like kwrite, use: kwrite $(grep "SearchedString" $(find . -name "*.cpp" -o -name "*.h" -o -name "*.ui") | cut -d":" -f1 | uniq) 2. When you have saved all your changes, prepare a patch with this command: svn diff > typos.patch 3. Send the file "typos.patch" as a bug report. Most of the time, the patches should apply to kde3 and trunk, so you don't have to prepare a separate one for each. I am attaching a patch for the typos mentioned above, with only one exception and two questions: > 8. Quite a few strings start with "Select here..." or "[Verb] here...". > It is more natural in English to write, "Here, select..." or > "Here, [verb]...", or to put the "here" part at the end of the sentence > (see the next item for an example). I haven't changed them yet, because these were so many, and it would create more risk for applying the patch to trunk as well. A developer has to decide, whether all these should really be changed. Isn't that also a big burden on translators, if they have to re-translate because of such small changes? > 88. > - shadows-very > + shadows — very The spaces are clear, but is it (technically) possible to use special characters like the long dash in these cases? I did this in my patch, but am not sure, whether it is ok. Same below: > 144. Supported features: > • Thumbnails: %5\n > • Delete items: %6\n > • Upload items: %7\n > • Create directories: %8\n > • Delete directories: %9\n Is is technically possible to use the dot? This is done in my patch as well. Cheers, Frank Frank, Just to clarify some points : - digiKam is under KDE4 port in svn into trunk. All strings still untouched at this place until the port will be complete (60% done actually) - If something is changed in KDE3 branch, the fix must be backported on KDE4 (trunk). just take a care than all must compile before to commit. - I'm always agree than translations team fix directly source code about i18n. Just take a care to follow all development plans : for example, if strings are frozen nothing must be changed. Developpers aren't native English (especially me (:=))) Thanks in advance for your help Gilles Caulier > > 88.
> > - shadows-very
> > + shadows — very
>
> The spaces are clear, but is it (technically) possible to use special
> characters like the long dash in these cases?
Developer will decide but IMO it should be avoided. Special characters
are available in Unicode fonts only. AFAIK Qt doesn't replace missing
glyphs (see tests for Konq) so if user will chose in interface font
where those glyphs are unavailable (s)he will not see them and there is
possibility user may not understand message.
It would be nice if applications would follow all typographic rules but
it would be better to play it safe.
----------------------------------------------------
Zobacz, co m
> - digiKam is under KDE4 port in svn into trunk. All strings still untouched
> at this place until the port will be complete (60% done actually)
>
> - If something is changed in KDE3 branch, the fix must be backported on
> KDE4 (trunk). just take a care than all must compile before to commit.
Ok, I should have stated more explicitely that my patch is for the KDE3 branch. I don't know how good svn's merge mechanism works, and thus if you can easily merge the change to trunk. I don't have a KDE4 environment installed right now, so I can't test digikam's trunk.
Please tell me, if you need anything else from me. As Mik stated, you might want to replace the long dash in line 199 of the patch, and the bullets in line 1954-1958 of the patch, by simple dashes.
To save me going through all those pages of the KDE Bug Wizard again, here are a few errors I found in the KDE4 digikam.po file: digiKam KDE4 bugs 1. This string, when converted for KDE4, has retained the comment in the msgid field, and does not show the original string needing translation. The comment should be converted to the msgctxt field. I think the original string is probably "Pictures". #: digikam/digikamfirstrun.cpp:89 msgid "This is a path name so you should include the slash in the translation" msgstr "/Hình" - msgid "This is a path name so you should include the slash in the translation" + msgctxt "This is a path name so you should include the slash in the translation" msgid "/Pictures" 2. The database is not valid: The \"DBVersion\" setting does not exist. The current database schema version cannot be verified. Try to start with an empty database. - valid: The + valid: the 3. Failed to create tables on database.\n - on database + in database 4. <qt><p>Failed to open the database. Error message from database: %1 </ p><p>You cannot use digiKam without a working database.Please check the database settings in the configuration menu.</p></qt> - database.Please + database. Please 5. <p>If this option is enabled, thumbnails bar will be displayed horizontally behind image area. You need to restart showFoto for this option take effect. <p> - <p>If this option is enabled, thumbnails bar will be displayed horizontally behind image area. You need to restart showFoto for this option take effect. <p> + <p>If this option is enabled, the thumbnails bar will be displayed horizontally behind the image area. You need to restart showFoto for this option take effect. <p> 6. Save Images Files Settings Do you mean: Save Images' Files' Settings (Save the settings about files for all the images) or Save Image's File Settings (Save the file settings for this image) ? __________________ Clytie, This file can be processed by a non developper. Just search i18n string over the source code and make a patch against svn. IMPORTANT : the KDE3 _and_ KDE4 source must be parsed at the same time. Both branches must be fixed at the same time to still homogenous. Thanks in advance Gilles Caulier Arnd, What we can do with this file ??? Gilles Gilles, let me take care of this, I'll report when I'm finished Gerhard Gerhard, This file still valid ? Gilles Caulier Arnd, Mik, Gerhard, Somebody can check seriously this report and fix all i18n strings relevant in source code ? Just make a patch and i can apply it to svn. Unforget than both KDE3 and KDE4 strings need to be fixed. This job can be done by a non developper. It simple to do... Thanks in advance for your help Gilles Caulier Oliver, Can you take a look if all typos reported here still valid and fix strings relevant to source code ? Thanks in advance for you help. Gilles Caulier Checked the first 9 reports and fixed 1, 4, 5, I could not find 2, 3, 6, 7 so i think they are already fixed 8 was to unspecific to find. Will continue to work on it tomorrow Oliver SVN commit 792358 by doerr: CCBUGS: 147597 M +1 -1 jp2ksettings.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=792358 SVN commit 792360 by doerr: CCBUGS: 147597 M +1 -1 imagedescedittab.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=792360 SVN commit 792361 by doerr: CCBUGS: 147597 M +4 -4 imagedescedittab.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=792361 SVN commit 792624 by doerr: CCBUGS: 147597 M +2 -2 timelineview.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=792624 SVN commit 792627 by doerr: CCBUGS: 147597 M +3 -3 imageeffect_hsl.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=792627 SVN commit 792633 by doerr: CCBUGS: 147597 M +2 -2 imageeffect_autocorrection.cpp M +2 -2 imageeffect_bcg.cpp M +2 -2 imageeffect_bwsepia.cpp M +2 -2 imageeffect_iccproof.cpp M +2 -2 imageeffect_redeye.cpp M +2 -2 imageeffect_rgb.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=792633 SVN commit 792638 by doerr: CCBUGS: 147597 M +2 -2 adjustcurves/adjustcurves.cpp M +5 -5 channelmixer/channelmixer.cpp M +3 -3 colorfx/imageeffect_colorfx.cpp M +4 -4 whitebalance/imageeffect_whitebalance.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=792638 SVN commit 792640 by doerr: CCBUGS: 147597 M +8 -8 imagepropertiescolorstab.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=792640 SVN commit 792644 by doerr: CCBUGS: 147597 M +2 -2 imageplugins/freerotation/imageeffect_freerotation.cpp M +8 -8 libs/imageproperties/imagepropertiescolorstab.cpp M +2 -2 utilities/setup/cameraselection.cpp M +2 -2 utilities/setup/setupalbumview.cpp M +1 -1 utilities/setup/setupicc.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=792644 SVN commit 792646 by doerr: CCBUGS: 147597 M +19 -19 adjustlevels/adjustlevels.cpp M +1 -1 inpainting/imageeffect_inpainting.cpp M +1 -1 inserttext/imageeffect_inserttext.cpp M +1 -1 restoration/imageeffect_restoration.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=792646 SVN commit 792650 by doerr: CCBUGS: 147597 M +2 -2 adjustcurves/adjustcurves.cpp M +1 -1 border/imageeffect_border.cpp M +8 -8 channelmixer/channelmixer.cpp M +3 -3 colorfx/imageeffect_colorfx.cpp M +4 -4 whitebalance/imageeffect_whitebalance.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=792650 SVN commit 792653 by doerr: CCBUGS: 147597 M +3 -3 hsl/imageeffect_hsl.cpp M +2 -2 imageeffect_autocorrection.cpp M +2 -2 imageeffect_bwsepia.cpp M +2 -2 imageeffect_iccproof.cpp M +2 -2 ratiocrop/imageeffect_ratiocrop.cpp M +1 -1 sharpnesseditor/imageeffect_sharpen.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=792653 SVN commit 792657 by doerr: CCBUGS: 147597 M +1 -1 digikam/ratingfilter.cpp M +2 -2 digikam/timelineview.cpp M +1 -1 imageplugins/blurfx/imageeffect_blurfx.cpp M +2 -2 imageplugins/coreplugin/imageeffect_bcg.cpp M +2 -2 imageplugins/coreplugin/imageeffect_redeye.cpp M +2 -2 imageplugins/coreplugin/imageeffect_rgb.cpp M +1 -1 imageplugins/distortionfx/imageeffect_distortionfx.cpp M +1 -1 utilities/cameragui/cameraui.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=792657 SVN commit 792659 by doerr: CCBUGS: 147597 M +9 -9 imageplugins/adjustlevels/adjustlevels.cpp M +1 -1 imageplugins/freerotation/imageeffect_freerotation.cpp M +1 -1 imageplugins/inpainting/imageeffect_inpainting.cpp M +2 -2 imageplugins/inserttext/imageeffect_inserttext.cpp M +1 -1 imageplugins/restoration/imageeffect_restoration.cpp M +1 -1 utilities/cameragui/cameraui.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=792659 SVN commit 792662 by doerr: CCBUGS: 147597 M +1 -1 digikam/ratingfilter.cpp M +1 -1 imageplugins/blurfx/imageeffect_blurfx.cpp M +1 -1 imageplugins/border/imageeffect_border.cpp M +2 -2 imageplugins/coreplugin/ratiocrop/imageeffect_ratiocrop.cpp M +1 -1 imageplugins/coreplugin/sharpnesseditor/imageeffect_sharpen.cpp M +1 -1 imageplugins/distortionfx/imageeffect_distortionfx.cpp M +2 -2 utilities/setup/cameraselection.cpp M +1 -1 utilities/setup/setupgeneral.cpp M +1 -1 utilities/setup/setupicc.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=792662 SVN commit 792664 by doerr: CCBUGS: 147597 M +4 -4 deletedialog.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=792664 SVN commit 792665 by doerr: CCBUGS: 147597 M +4 -4 deletedialog.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=792665 SVN commit 792666 by doerr: CCBUGS: 147597 M +1 -1 deletedialog.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=792666 SVN commit 792667 by doerr: CCBUGS: 147597 M +1 -1 deletedialog.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=792667 Fixed 9 - 13 for KDE3 and 4. Will continue to work on 14+ tomorrow. Oliver, Sound like this file take a while to fix. right? I have planed to release 0.9.4-beta3 with i18n freeze for this week end. If it's too short for you, i can delay of course. Gilles yes it is too short, but i would not delay the string freeze. I think that i need a couple of weeks till i fixed everyting. So i will try to fix as much as i can in front of the string freeze and will continue to work on it, when we string freeze is over Is this ok for you Oliver Oliver, Currently the release plan is: 2008-04-06: Beta 3 (i18n freeze) 2008-04-20: Release candidate 2008-04-27: Final release ... i can change like this : 2008-04-06: Beta 3 2008-04-20: Release candidate (i18n freeze) 2008-05-04: Final release Your viewpoint ? Gilles I can't guarantee that the bug will be completely fixed, but the time will be useful. Oliver ok, release plan fixed... Gilles Oliver, I have added a 0.9.4-beta4 and 0.9.4-beta5 in release plan. Please, let's me hear when this file is closed and when i will freeze i18n. Best Gilles SVN commit 795961 by doerr: CCBUGS: 147597 Fixed 14 M +1 -1 dialogs/imageguidedlg.cpp M +1 -1 widgets/imageplugins/imagepannelwidget.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=795961 SVN commit 795962 by doerr: CCBUGS: 147597 Fixed 14 M +1 -1 dialogs/imageguidedlg.cpp M +1 -1 widgets/imageplugins/imagepannelwidget.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=795962 Hi Gilles, i would not take care of this bug for the releases. It contains only spelling errors and it will take me a few weeks till i fixed everything. I just fixed 15 out of more than 140... Oliver SVN commit 795964 by doerr: CCBUGS: 147597 Fixed 15 and 18, could not find 16+17 M +5 -5 greycstorationwidget.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=795964 SVN commit 795966 by doerr: CCBUGS: 147597 Fixed 15 - 18 M +8 -8 greycstorationwidget.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=795966 SVN commit 795967 by doerr: CCBUGS: 147597 Fixed 16 and 17 M +4 -4 greycstorationwidget.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=795967 SVN commit 795968 by doerr: CCBUGS: 147597 Fixed 19 M +3 -3 greycstorationwidget.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=795968 SVN commit 795969 by doerr: CCBUGS: 147597 Fixed 19 M +3 -3 greycstorationwidget.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=795969 SVN commit 795970 by doerr: CCBUGS: 147597 Fixed 20 M +1 -1 digikam/digikamapp.cpp M +2 -2 libs/widgets/metadata/metadatawidget.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=795970 SVN commit 795971 by doerr: CCBUGS: 147597 Fixed 20 M +2 -2 metadatawidget.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=795971 SVN commit 795972 by doerr: CCBUGS: 147597 Fixed 21 + 22 M +4 -4 iccprofilewidget.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=795972 SVN commit 795973 by doerr: CCBUGS: 147597 Fixed 21+22 M +4 -4 iccprofilewidget.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=795973 SVN commit 795974 by doerr: CCBUGS: 147597 Fixed 21 + 22 M +3 -3 iccprofilewidget.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=795974 could not find 23 SVN commit 795984 by doerr: CCBUGS: 147597 Fixed 25 M +4 -4 imagewidget.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=795984 SVN commit 795985 by doerr: CCBUGS: 147597 Fixed 25 M +4 -4 imagewidget.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=795985 Hi Gilles, could you clarify 26 <p>Set this option on to display pure black over-colored on preview. This will help you to avoid under-exposing the image. <p>Set this option on to display pure white over-colored on preview. This will help you to avoid over-exposing the image. I don't know what you mean by "pure [colour] over-colored on preview". Do you mean "overlaid", from the word "overlay"? + overlaid on the preview ? "Pure black" is _black_ color [RGB(0,0,0) in 8bits color depth]. "Pure white" is _white_ color [RGB(255,255,255) in 8bits color depth] When you turn on these options you can see over-exposed and under-exposed area over the image. Gilles SVN commit 796286 by doerr: CCBUGS: 147597 Fixed 26 M +4 -4 imagewidget.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=796286 SVN commit 796287 by doerr: CCBUGS: 147597 Fixed 26 M +4 -4 imagewidget.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=796287 SVN commit 796288 by doerr: CCBUGS: 147597 Fixed 27-29 M +2 -2 scanlib.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=796288 SVN commit 796289 by doerr: CCBUGS: 147597 Fixed 27, 28+29 not found M +2 -2 firstrun.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=796289 SVN commit 796290 by doerr: CCBUGS: 147597 Fixed 28 M +2 -2 firstrun.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=796290 SVN commit 797044 by doerr: CCBUGS: 147597 Fixed 31, 33,34, 30+32 not found M +2 -2 albummanager.cpp M +1 -1 scanlib.cpp M +1 -1 searchadvanceddialog.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=797044 SVN commit 797045 by doerr: CCBUGS: 147597 Fixed 33+34, 30-32 not found M +2 -2 albummanager.cpp M +1 -1 searchadvanceddialog.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=797045 SVN commit 797047 by doerr: CCBUGS: 147597 Fixed 35+36 M +1 -1 digikam/digikamapp.cpp M +1 -1 imageplugins/coreplugin/imageeffect_iccproof.cpp M +2 -2 utilities/imageeditor/canvas/dimginterface.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=797047 SVN commit 797049 by doerr: CCBUGS: 147597 Fixed 35+36 M +2 -2 digikam/digikamapp.cpp M +1 -1 imageplugins/coreplugin/imageeffect_iccproof.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=797049 SVN commit 797053 by doerr: CCBUGS: 147597 Fixed 37-42 M +4 -4 digikam/digikamapp.cpp M +1 -1 digikam/searchquickdialog.cpp M +2 -2 showfoto/setup/setupeditor.cpp M +1 -1 utilities/imageeditor/editor/editorwindow.cpp M +1 -1 utilities/imageeditor/editor/imagewindow.cpp M +2 -2 utilities/lighttable/lighttablewindow.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=797053 SVN commit 797054 by doerr: CCBUGS: 147597 Fixed 37-part2 M +1 -1 digikamapp.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=797054 SVN commit 797058 by doerr: CCBUGS: 147597 Fixed 37-42 M +4 -4 digikam/digikamapp.cpp M +1 -1 digikam/searchadvanceddialog.cpp M +1 -1 digikam/searchquickdialog.cpp M +2 -2 showfoto/setup/setupeditor.cpp M +1 -1 utilities/cameragui/cameraui.cpp M +1 -1 utilities/imageeditor/editor/imagewindow.cpp M +1 -1 utilities/kipiiface/kipiinterface.cpp M +1 -1 utilities/lighttable/lighttablewindow.cpp M +2 -2 utilities/setup/setupeditor.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=797058 SVN commit 797713 by doerr: CCBUGS: 147597 Fixed 43-46 M +2 -2 showfoto/setup/setupeditor.cpp M +2 -2 showfoto/setup/setuptooltip.cpp M +1 -1 utilities/setup/setup.cpp M +2 -2 utilities/setup/setupeditor.cpp M +6 -6 utilities/setup/setupslideshow.cpp M +13 -13 utilities/setup/setuptooltip.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=797713 SVN commit 797720 by doerr: CCBUGS: 147597 Fixed 43-46 M +2 -2 showfoto/setup/setupeditor.cpp M +1 -1 showfoto/setup/setuptooltip.cpp M +7 -7 utilities/cameragui/renamecustomizer.cpp M +2 -2 utilities/setup/setup.cpp M +2 -2 utilities/setup/setupeditor.cpp M +2 -2 utilities/setup/setupmime.cpp M +1 -1 utilities/setup/setupslideshow.cpp M +13 -13 utilities/setup/setuptooltip.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=797720 SVN commit 797724 by doerr: CCBUGS: 147597 Fixed 47-50 M +8 -8 showfoto/setup/setuptooltip.cpp M +3 -3 utilities/setup/setuptooltip.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=797724 SVN commit 797727 by doerr: CCBUGS: 147597 Fixed 47-50 M +8 -8 showfoto/setup/setuptooltip.cpp M +2 -2 utilities/setup/setuptooltip.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=797727 SVN commit 798224 by doerr: CCBUGS: 147597 Fixed 51-54 M +2 -2 libs/dialogs/deletedialogbase.ui M +4 -4 showfoto/setup/setuptooltip.cpp M +1 -1 showfoto/showfoto.cpp M +2 -2 utilities/imageeditor/editor/imagewindow.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=798224 SVN commit 798226 by doerr: CCBUGS: 147597 Fixed 51-54 M +1 -1 libs/dialogs/deletedialogbase.ui M +6 -6 showfoto/setup/setuptooltip.cpp M +1 -1 showfoto/showfoto.cpp M +2 -2 utilities/imageeditor/editor/imagewindow.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=798226 SVN commit 798233 by doerr: CCBUGS: 147597 Fixed 55-59 M +1 -1 imageplugins/blurfx/imageeffect_blurfx.cpp M +3 -3 imageplugins/colorfx/imageeffect_colorfx.cpp M +1 -1 imageplugins/coreplugin/sharpnesseditor/imageeffect_sharpen.cpp M +1 -1 imageplugins/distortionfx/imageeffect_distortionfx.cpp M +2 -2 imageplugins/noisereduction/imageeffect_noisereduction.cpp M +1 -1 imageplugins/texture/imageeffect_texture.cpp M +2 -2 libs/dialogs/deletedialogbase.ui WebSVN link: http://websvn.kde.org/?view=rev&revision=798233 SVN commit 798247 by doerr: CCBUGS: 147597 Fixed 55-59 M +1 -1 imageplugins/blurfx/imageeffect_blurfx.cpp M +3 -3 imageplugins/colorfx/imageeffect_colorfx.cpp M +1 -1 imageplugins/coreplugin/sharpnesseditor/imageeffect_sharpen.cpp M +1 -1 imageplugins/distortionfx/imageeffect_distortionfx.cpp M +2 -2 imageplugins/noisereduction/imageeffect_noisereduction.cpp M +1 -1 imageplugins/texture/imageeffect_texture.cpp M +2 -2 libs/dialogs/deletedialogbase.ui WebSVN link: http://websvn.kde.org/?view=rev&revision=798247 SVN commit 798655 by doerr: CCBUGS: 147597 Fixed 60-66 M +4 -4 border/imageeffect_border.cpp M +5 -5 distortionfx/imageeffect_distortionfx.cpp M +1 -1 freerotation/imageeffect_freerotation.cpp M +2 -2 inserttext/fontchooserwidget.cpp M +1 -1 inserttext/imageeffect_inserttext.cpp M +1 -1 sheartool/imageeffect_sheartool.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=798655 SVN commit 798657 by doerr: CCBUGS: 147597 Fixed 60-part2 M +1 -1 imageeffect_inserttext.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=798657 SVN commit 798668 by doerr: CCBUGS: 147597 Fixed 60, 61-66 M +3 -3 border/imageeffect_border.cpp M +6 -6 distortionfx/imageeffect_distortionfx.cpp M +1 -1 freerotation/imageeffect_freerotation.cpp M +1 -1 inserttext/imageeffect_inserttext.cpp M +1 -1 raindrop/imageeffect_raindrop.cpp M +1 -1 sheartool/imageeffect_sheartool.cpp M +1 -1 superimpose/imageeffect_superimpose.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=798668 SVN commit 807023 by doerr: CCBUGS: 147597 Fixed 66-71 M +1 -1 coreplugin/hsl/imageeffect_hsl.cpp M +1 -1 coreplugin/imageeffect_iccproof.cpp M +4 -4 coreplugin/sharpnesseditor/imageeffect_sharpen.cpp M +1 -1 infrared/imageeffect_infrared.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=807023 SVN commit 807029 by doerr: CCBUGS: 147597 Fixed 66-71 M +1 -1 coreplugin/hsl/imageeffect_hsl.cpp M +2 -2 coreplugin/imageeffect_iccproof.cpp M +5 -5 coreplugin/sharpnesseditor/imageeffect_sharpen.cpp M +1 -1 infrared/imageeffect_infrared.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=807029 SVN commit 807034 by doerr: CCBUGS: 147597 Fixed 72-73 M +4 -4 imageeffect_iccproof.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=807034 SVN commit 807037 by doerr: CCBUGS: 147597 Fixed 72-73 M +4 -4 imageeffect_iccproof.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=807037 SVN commit 807043 by doerr: CCBUGS: 147597 Fixed 74-79 M +10 -10 imageeffect_iccproof.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=807043 SVN commit 807046 by doerr: CCBUGS: 147597 Fixed 74-79 M +12 -12 imageeffect_iccproof.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=807046 SVN commit 808763 by doerr: CCBUGS: 147597 Fixed 80-82 M +1 -1 imageeffect_bwsepia.cpp M +4 -4 ratiocrop/imageeffect_ratiocrop.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=808763 SVN commit 809229 by doerr: CCBUGS: 147597 Fixed 83-90 M +16 -16 imageeffect_bwsepia.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=809229 SVN commit 809237 by doerr: CCBUGS: 147597 Fixed 80-90 M +17 -17 imageeffect_bwsepia.cpp M +4 -4 ratiocrop/imageeffect_ratiocrop.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=809237 SVN commit 809342 by doerr: CCBUGS: 147597 Fixed 91-102 M +2 -2 imageplugins/coreplugin/imageeffect_redeye.cpp M +3 -3 utilities/batch/batchalbumssyncmetadata.cpp M +1 -1 utilities/batch/batchsyncmetadata.cpp M +2 -2 utilities/batch/batchthumbsgenerator.cpp M +2 -2 utilities/cameragui/cameraui.cpp M +2 -2 utilities/setup/setuplighttable.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=809342 SVN commit 809362 by doerr: CCBUGS: 147597 Fixed 91-102 M +1 -1 imageplugins/coreplugin/imageeffect_redeye.cpp M +3 -3 utilities/batch/batchalbumssyncmetadata.cpp M +1 -1 utilities/batch/batchsyncmetadata.cpp M +2 -2 utilities/batch/batchthumbsgenerator.cpp M +2 -2 utilities/cameragui/cameraui.cpp M +2 -2 utilities/setup/setuplighttable.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=809362 SVN commit 811049 by doerr: CCBUGS: 147597 Fixed 103-109, could not find 104 M +2 -2 setup.cpp M +14 -14 setupgeneral.cpp M +2 -2 setupmetadata.cpp M +6 -6 setupmime.cpp M +6 -6 setupslideshow.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=811049 SVN commit 811052 by doerr: CCBUGS: 147597 Fixed 103-109, could not find 104 M +1 -1 setupmime.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=811052 SVN commit 811055 by doerr: CCBUGS: 147597 Fixed 102-109 M +2 -2 setup.cpp M +14 -14 setupalbumview.cpp M +6 -6 setupmetadata.cpp M +6 -6 setupmime.cpp M +9 -9 setupslideshow.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=811055 SVN commit 811107 by doerr: CCBUGS: 147597 Fixed 110-120 M +7 -7 setupgeneral.cpp M +11 -11 setupicc.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=811107 SVN commit 811113 by doerr: CCBUGS: 147597 Fixed 110-120, could not find 104 M +6 -6 setupalbumview.cpp M +1 -1 setupcollections.cpp M +11 -11 setupicc.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=811113 SVN commit 811326 by doerr: CCBUGS: 147597 Fixed 121-130 and remark from Andi Clemens M +3 -3 imageeditor/canvas/colorcorrectiondlg.cpp M +3 -3 imageeditor/tools/imageresize.cpp M +5 -5 setup/cameraselection.cpp M +1 -1 setup/setupgeneral.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=811326 SVN commit 811338 by doerr: CCBUGS: 147597 Fixed 121-130 and remark from Andi Clemens M +4 -4 imageeditor/canvas/colorcorrectiondlg.cpp M +3 -3 imageeditor/tools/imageresize.cpp M +1 -1 lighttable/lighttablewindow.cpp M +5 -5 setup/cameraselection.cpp M +1 -1 setup/setupalbumview.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=811338 SVN commit 811920 by doerr: CCBUGS: 147597 Fixed 131-145, thats the original bug report from Clytie, will have to check the rest M +2 -2 cameragui/cameracontroller.cpp M +1 -1 cameragui/cameraiconview.cpp M +10 -10 cameragui/cameraui.cpp M +5 -5 cameragui/gpcamera.cpp M +7 -7 cameragui/renamecustomizer.cpp M +3 -3 cameragui/umscamera.cpp M +2 -2 lighttable/lighttablewindow.cpp M +4 -4 setup/setupmetadata.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=811920 SVN commit 811923 by doerr: CCBUGS: 147597 Fixed 131-145, thats the original bug report from Clytie, will have to check the rest M +2 -2 cameracontroller.cpp M +1 -1 cameraiconview.cpp M +8 -8 cameraui.cpp M +6 -6 gpcamera.cpp M +7 -7 renamecustomizer.cpp M +9 -9 umscamera.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=811923 On Sat, 24 May 2008, [ISO-8859-15] Oliver Dörr wrote: > Hi, > > just fixed http://bugs.kde.org/show_bug.cgi?id=147597 > > Could somebody close this bug? > > Thanks > Oliver Oliver, thanks a lot for your persistent effort in dealing with the typos. This is very much appreciated!!! Closing this bug as fixed. Best, Arnd Gilles, maybe closing this was too quick: you have to backport these patches to KDE4, right? Arnd, Well, if i not too wrong, Oliver has already backported in fixes in KDE4... Oliver, You have done an incredible work. Thanks a lots. It will be time to release next beta version with frozen i18n. Gilles Yes, i fixed everything for KDE3 and KDE4. So there should be no need for a backport Oliver |