Summary: | Some icons are missing | ||
---|---|---|---|
Product: | [Applications] digikam | Reporter: | Jan Schneider <jan> |
Component: | Usability-Themes | Assignee: | Digikam Developers <digikam-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | caulier.gilles |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 0.9.3 | |
Sentry Crash Report: |
Description
Jan Schneider
2007-06-26 19:39:31 UTC
I think this is the "Colors"/"Levels Adjust" entry in the image editor, right? I can reproduce this with current svn. It is very weird: The three pipette icons for "All channels shadow tone color picker", middle and highlight appear as three small dots. Interestingly, if I then leave that tool, go to the "Curves Adjust", leave that and go back to "Levels adjust", the first and third of the pipette ones appear. I can confirm the weird behaviour when going to the Curves dialog. Not reproductible here. I have installed a fresh computer to my son school yesterday, using current svn, and all is fine. The png files used for picker color buttons are in digikam/data/pics/ and named : color-picker-black.png color-picker-grey.png color-picker-white.png 3 files are installed in digiKam data folders from your KDE application install dir. Here under mandriva, we have: /usr/bin/install -c -p -m 644 'color-picker-black.png' '/usr/share/apps/digikam/data/color-picker-black.png' /usr/bin/install -c -p -m 644 'color-picker-grey.png' '/usr/share/apps/digikam/data/color-picker-grey.png' /usr/bin/install -c -p -m 644 'color-picker-white.png' '/usr/share/apps/digikam/data/color-picker-white.png' in AdjustCurves plugin dialog code, we have : ... m_pickBlack = new QPushButton(m_pickerColorButtonGroup); m_pickerColorButtonGroup->insert(m_pickBlack, BlackTonal); KGlobal::dirs()->addResourceType("color-picker-black", KGlobal::dirs()->kde_default("data") + "digikam/data"); directory = KGlobal::dirs()->findResourceDir("color-picker-black", "color-picker-black.png"); m_pickBlack->setPixmap( QPixmap( directory + "color-picker-black.png" ) ); ... Which work perfectly... Gilles The AdjustColors plugin works fine. It's the AdjustLevels plugin that fails. And now that you mentioned SVN, I have taken a look at the differences between these plugins: while AdjustColors is loading the picker icons from digikam/data/, AdjustLevels is loading them from digikamplugins/data/. At least on my installation this directory doesn't even exist. SVN commit 682126 by cgilles: digikam from KDE3 branch : fix director which host shared image used by image plugins BUG: 147263 M +3 -3 adjustlevels/adjustlevels.cpp M +1 -1 border/imageeffect_border.cpp M +1 -1 texture/imageeffect_texture.cpp --- branches/extragear/kde3/graphics/digikam/imageplugins/adjustlevels/adjustlevels.cpp #682125:682126 @@ -250,7 +250,7 @@ m_pickBlack = new QPushButton(m_pickerColorButtonGroup); m_pickerColorButtonGroup->insert(m_pickBlack, BlackTonal); KGlobal::dirs()->addResourceType("color-picker-black", KGlobal::dirs()->kde_default("data") + - "digikamimageplugins/data"); + "digikam/data"); directory = KGlobal::dirs()->findResourceDir("color-picker-black", "color-picker-black.png"); m_pickBlack->setPixmap( QPixmap( directory + "color-picker-black.png" ) ); m_pickBlack->setToggleButton(true); @@ -260,7 +260,7 @@ m_pickGray = new QPushButton(m_pickerColorButtonGroup); m_pickerColorButtonGroup->insert(m_pickGray, GrayTonal); KGlobal::dirs()->addResourceType("color-picker-gray", KGlobal::dirs()->kde_default("data") + - "digikamimageplugins/data"); + "digikam/data"); directory = KGlobal::dirs()->findResourceDir("color-picker-gray", "color-picker-gray.png"); m_pickGray->setPixmap( QPixmap( directory + "color-picker-gray.png" ) ); m_pickGray->setToggleButton(true); @@ -270,7 +270,7 @@ m_pickWhite = new QPushButton(m_pickerColorButtonGroup); m_pickerColorButtonGroup->insert(m_pickWhite, WhiteTonal); KGlobal::dirs()->addResourceType("color-picker-white", KGlobal::dirs()->kde_default("data") + - "digikamimageplugins/data"); + "digikam/data"); directory = KGlobal::dirs()->findResourceDir("color-picker-white", "color-picker-white.png"); m_pickWhite->setPixmap( QPixmap( directory + "color-picker-white.png" ) ); m_pickWhite->setToggleButton(true); --- branches/extragear/kde3/graphics/digikam/imageplugins/border/imageeffect_border.cpp #682125:682126 @@ -645,7 +645,7 @@ } KGlobal::dirs()->addResourceType(pattern.ascii(), KGlobal::dirs()->kde_default("data") + - "digikamimageplugins/data"); + "digikam/data"); return (KGlobal::dirs()->findResourceDir(pattern.ascii(), pattern + ".png") + pattern + ".png" ); } --- branches/extragear/kde3/graphics/digikam/imageplugins/texture/imageeffect_texture.cpp #682125:682126 @@ -283,7 +283,7 @@ } KGlobal::dirs()->addResourceType(pattern.ascii(), KGlobal::dirs()->kde_default("data") + - "digikamimageplugins/data"); + "digikam/data"); return (KGlobal::dirs()->findResourceDir(pattern.ascii(), pattern + ".png") + pattern + ".png" ); } SVN commit 682128 by cgilles: digikam from trunk (KDE4): backport B.K.O #147263 from KDE3 branch CCBUGS: 147263 M +3 -3 adjustlevels/adjustlevels.cpp M +1 -1 border/imageeffect_border.cpp M +1 -1 texture/imageeffect_texture.cpp --- trunk/extragear/graphics/digikam/imageplugins/adjustlevels/adjustlevels.cpp #682127:682128 @@ -254,7 +254,7 @@ m_pickBlack = new QPushButton(m_pickerColorButtonGroup); m_pickerColorButtonGroup->insert(m_pickBlack, BlackTonal); KGlobal::dirs()->addResourceType("color-picker-black", KGlobal::dirs()->kde_default("data") + - "digikamimageplugins/data"); + "digikam/data"); directory = KGlobal::dirs()->findResourceDir("color-picker-black", "color-picker-black.png"); m_pickBlack->setPixmap( QPixmap( directory + "color-picker-black.png" ) ); m_pickBlack->setToggleButton(true); @@ -264,7 +264,7 @@ m_pickGray = new QPushButton(m_pickerColorButtonGroup); m_pickerColorButtonGroup->insert(m_pickGray, GrayTonal); KGlobal::dirs()->addResourceType("color-picker-gray", KGlobal::dirs()->kde_default("data") + - "digikamimageplugins/data"); + "digikam/data"); directory = KGlobal::dirs()->findResourceDir("color-picker-gray", "color-picker-gray.png"); m_pickGray->setPixmap( QPixmap( directory + "color-picker-gray.png" ) ); m_pickGray->setToggleButton(true); @@ -274,7 +274,7 @@ m_pickWhite = new QPushButton(m_pickerColorButtonGroup); m_pickerColorButtonGroup->insert(m_pickWhite, WhiteTonal); KGlobal::dirs()->addResourceType("color-picker-white", KGlobal::dirs()->kde_default("data") + - "digikamimageplugins/data"); + "digikam/data"); directory = KGlobal::dirs()->findResourceDir("color-picker-white", "color-picker-white.png"); m_pickWhite->setPixmap( QPixmap( directory + "color-picker-white.png" ) ); m_pickWhite->setToggleButton(true); --- trunk/extragear/graphics/digikam/imageplugins/border/imageeffect_border.cpp #682127:682128 @@ -649,7 +649,7 @@ } KGlobal::dirs()->addResourceType(pattern.ascii(), KGlobal::dirs()->kde_default("data") + - "digikamimageplugins/data"); + "digikam/data"); return (KGlobal::dirs()->findResourceDir(pattern.ascii(), pattern + ".png") + pattern + ".png" ); } --- trunk/extragear/graphics/digikam/imageplugins/texture/imageeffect_texture.cpp #682127:682128 @@ -286,7 +286,7 @@ } KGlobal::dirs()->addResourceType(pattern.ascii(), KGlobal::dirs()->kde_default("data") + - "digikamimageplugins/data"); + "digikam/data"); return (KGlobal::dirs()->findResourceDir(pattern.ascii(), pattern + ".png") + pattern + ".png" ); } |