Summary: | [PATCH] After compact action mail list disappears | ||
---|---|---|---|
Product: | [Unmaintained] kmail | Reporter: | S. Umar <umar> |
Component: | mbox | Assignee: | kdepim bugs <kdepim-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | jjm, kde, rdieter |
Priority: | NOR | ||
Version: | 1.9.7 | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: | |||
Attachments: |
Experimental patch to fix problem
Another expermimental patch |
Description
S. Umar
2007-06-19 17:34:32 UTC
I have tested generic 3.5.7 and it has the same problem, so it is not recent svn changes. Can reproduce here too, on both 3.5 and work branches, but only for mbox folders (maildir folders seem OK). The attached patch appears to fix the problem, although I don't know if it is the best way to fix it. Could you please try it out and report? Created attachment 20957 [details]
Experimental patch to fix problem
Please do not try this patch. It can lead to the loss of mail. The mbox folder must be closed because the old mbox file is replaced by a new compacted version of the mbox file. Created attachment 20966 [details]
Another expermimental patch
As Ingo says, don't use the previous patch.
Here's another one which doesn't change anything to do with index generation,
but which ensures that the folder is reopened in the two cases where it is
needed.
*** Bug 147346 has been marked as a duplicate of this bug. *** Is this ready to be committed to SVN? I'd like a confirmation from the experts that this fix is the right thing to do. Have sent a message to the ML to this effect, but no response so far (everybody is probably away at aKademy). This should have been in 3.5.8. Very important problem effecting many users. Can it be done? Sammy From the kde-pim ML: From: Ingo Klöcker <kloecker@kde.org> Message-id: <200711062238.29142@erwin.ingo-kloecker.de> Subject: Re: [Kde-pim] compacting mbox shows empty folder On Tuesday 06 November 2007, Rex Dieter wrote: > See also, > http://bugs.kde.org/146967 > > Does the provided patch look good? Not really. It might fix the symptoms but it does not seem to fix the real problem. Anyway, the patch shouldn't hurt and thus it should probably be applied. Regards, Ingo SVN commit 733841 by marten: Fix "After compact action mail list disappears", by ensuring that the folder is open in the two places where it may be needed. BUG:146967 M +2 -2 compactionjob.cpp M +5 -0 kmheaders.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=733841 SVN commit 733843 by marten: Forward port of commit 733841 from 3.5 branch: Fix "After compact action mail list disappears", by ensuring that the folder is open in the two places where it may be needed. Not such a major issue now that maildir is the recommended format and mandatory for the standard folders. CCBUG:146967 M +2 -2 compactionjob.cpp M +6 -0 kmheaders.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=733843 |