Bug 146676

Summary:	wrong pascal code generation
Product:	[Applications] umbrello	Reporter:	Dmitry N. Kurashkin <dkur>
Component:	general	Assignee:	Umbrello Development Group <umbrello-devel>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:

Description Dmitry N. Kurashkin 2007-06-11 19:37:40 UTC

Version:           1.5.71 (using KDE KDE 3.5.6)
Installed from:    Ubuntu Packages
OS:                Linux

Independently of class name set on diagram, umbrello creates pascal unit with class described as "class TObject = object". In unit also presents description of pointer variable: "PObject = ^TObject". It's wrong too.
I have downloaded source code of umbrello and found problem in file pascalwriter.cpp. Now bug are fixed and tested, сorrected file can be found by link http://dkur.nm.ru/pascalwriter.cpp

Comment 1 Oliver Kellogg 2007-06-11 20:31:44 UTC

SVN commit 674094 by okellogg:

writeClass(): Use the classname instead of the fixed name "TObject".
Thanks to Dmitry N. Kurashkin for the patch.
BUG:146676


 M  +6 -0      ChangeLog  
 M  +1 -0      THANKS  
 M  +2 -2      umbrello/codegenerators/pascalwriter.cpp  


--- branches/KDE/3.5/kdesdk/umbrello/ChangeLog #674093:674094
@@ -1,3 +1,9 @@
+Version 1.5.72
+
+* Bugs/wishes from http://bugs.kde.org:
+* Umbrello appends ".xmi" to the saved diagram name when it is told not to do so (146061)
+* Wrong pascal code generation (146676)
+
 Version 1.5.71
 
 * Bugs/wishes from http://bugs.kde.org:
--- branches/KDE/3.5/kdesdk/umbrello/THANKS #674093:674094
@@ -49,6 +49,7 @@
 Piotr Kolaczkowski <P.Kolaczkowski @elka.pw.edu.pl>
 Matthias Kretz <kretz @kde.org>
 Thorsten Kunz <tk @bytecrash.net>
+Dmitry N. Kurashkin <dkur @nm.ru>
 Jari-Matti M