Bug 146020

what was the url that you tried to add?

btw, that debug is useless.

no exact URL I just entered the artist names witch on suse 10.2 and same amarok version where playable. Also previously this function was also ok for suse 10.1 same version. engage>play last.fm stream>custom station and then entered artist names. the after 3 seconds of streaming appears a message this item is not available for streaming.

I experienced the same issue with the last svn source.

SVN commit 670063 by seb:

Last.fm has changed the way we can listen to artist radios due to licensing. This means that we can't listen to the radio station from multiple artists. Only one artist from now on...

Sorry for the string breakage, but it is a critical fix.
CCMAIL: kde-i18n-doc@kde.org

BUG: 146020


 M  +4 -5      lastfm.cpp  
 M  +2 -2      playlistwindow.cpp  


--- branches/stable/extragear/multimedia/amarok/src/lastfm.cpp #670062:670063
@@ -222,10 +222,9 @@
     QString token;
     CustomStationDialog dialog( 0 );
 
-    if( dialog.exec() == QDialog::Accepted ) {
-        const QStringList artists = QStringList::split( ",", dialog.text() );
-        for( uint i = 0; i < artists.count(); i++ )
-            token += ( i > 0 ? "," : "" ) + artists[i].simplifyWhiteSpace();
+    if( dialog.exec() == QDialog::Accepted )
+    {
+        token =  dialog.text();
     }
 
     return token;
@@ -1080,7 +1079,7 @@
 {
     makeVBoxMainWidget();
 
-    new QLabel( i18n( "Enter the name of a band or artist you like:\n(You can enter multiple artists separated by commas)" ), mainWidget() );
+    new QLabel( i18n( "Enter the name of a band or artist you like:" ), mainWidget() );
 
     m_edit = new KLineEdit( mainWidget(), "CustomStationEdit" );
     m_edit->setFocus();
--- branches/stable/extragear/multimedia/amarok/src/playlistwindow.cpp #670062:670063
@@ -949,7 +949,7 @@
     const QString token = LastFm::Controller::createCustomStation();
     if( token.isEmpty() ) return;
 
-    const KURL url( "lastfm://artistnames/" + token );
+    const KURL url( "lastfm://artist/" + token + "/similarartists" );
     Playlist::instance()->insertMedia( url, Playlist::Append|Playlist::DirectPlay );
 }
 
@@ -959,7 +959,7 @@
     const QString token = LastFm::Controller::createCustomStation();
     if( token.isEmpty() ) return;
 
-    const KURL url( "lastfm://artistnames/" + token );
+    const KURL url( "lastfm://artist/" + token + "/similarartists" );
     Playlist::instance()->insertMedia( url );
 }
 

SVN commit 670067 by seb:

Forward port r670063 to trunk
CCBUG: 146020


 M  +4 -5      lastfm.cpp  
 M  +2 -2      playlistwindow.cpp  


--- trunk/extragear/multimedia/amarok/src/lastfm.cpp #670066:670067
@@ -235,10 +235,9 @@
     QString token;
     CustomStationDialog dialog( 0 );
 
-    if( dialog.exec() == QDialog::Accepted ) {
-        const QStringList artists = dialog.text().split( ',' );
-        for( int i = 0; i < artists.count(); i++ )
-            token += ( i > 0 ? "," : "" ) + artists[i].simplified();
+    if( dialog.exec() == QDialog::Accepted )
+    {
+        token = dialog.text();
     }
 
     return token;
@@ -1102,7 +1101,7 @@
     setMainWidget( vbox );
 
 
-    new QLabel( i18n( "Enter the name of a band or artist you like:\n(You can enter multiple artists separated by commas)" ), mainWidget() );
+    new QLabel( i18n( "Enter the name of a band or artist you like:" ), mainWidget() );
 
     m_edit = new KLineEdit( mainWidget() );
     m_edit->setFocus();
--- trunk/extragear/multimedia/amarok/src/playlistwindow.cpp #670066:670067
@@ -809,7 +809,7 @@
     const QString token = LastFm::Controller::createCustomStation();
     if( token.isEmpty() ) return;
 
-    const KUrl url( "lastfm://artistnames/" + token );
+    const KURL url( "lastfm://artist/" + token + "/similarartists" );
     Playlist::instance()->insertMedia( url, Playlist::Append|Playlist::DirectPlay );
 }
 
@@ -819,7 +819,7 @@
     const QString token = LastFm::Controller::createCustomStation();
     if( token.isEmpty() ) return;
 
-    const KUrl url( "lastfm://artistnames/" + token );
+    const KURL url( "lastfm://artist/" + token + "/similarartists" );
     Playlist::instance()->insertMedia( url, Playlist::Append|Playlist::DirectPlay  );
 }