Bug 145925

Version:            (using KDE KDE 3.5.6)
Installed from:    Ubuntu Packages
OS:                Linux

This bug is for Amarok 1.4.5 running with KDE 3.5.6 in Ubnutu.

The bug:
The function of smart play-lists when using "Label" as the field works in ways that are different from both my own expectation and the behavior of smart play-lists with conditions on other fields (besides "Label").

It seems like Amarok looks at a list of all known labels, compares each label to the condition, and if it passes adds all songs labeled with this label to a smart play-list.  This has the following unexpected side effects:
- Songs with multiple labels can show up on a play-list multiple times.
- Songs with multiple labels can show up on play-lists where one of their labels fails "Not" condition.
- Songs with no label cannot be on smart play-lists with "Matches All" + any Label-based condition (including things like Label + "Is not")

Four examples of this bug can be reproduced as follows:

Example 1:

- Label a song with two labels (For this example, "Label 1" and "Label 2")
- Create a Smart Play-list with the condition: "Matches any: Label + Does not contain: 'Label 1'"
- The song will show up on the play-list.  The play list will also contain all other songs with labels that do not match "Label 1" (once for each label they have that passes the condition).

Expected behavior was a playlist containing all songs in the collection except those that have a label matching "Label 1."  This differs from the actual results in the following ways:
 - Only songs with labels show up
 - Songs with multiple labels show up multiple times.
 - Songs with multiple labels and some of their labels contain "Label 1" show up on the list at all.

Example 2:

- Using the same song above (with labels "Label 1" and "Label 2")
- Create a Smart Play-list with a condition "Matches any: Label + Does not contain: 'Label 3'"
- The song will appear twice on the play-list.  The playlist will contain all other songs with labels (once for each label they have that passes the condition).

This example is the same as example one, except it explicitly demonstrates that a song with multiple labels will show up twice if a "Label + Not" condition is used and the collection contains a song with two labels that pass this condition.


Example 3:

- Label three songs as follows:
- Song 1 - "Label 1"
- Song 2 - "Label 2"
- Song 3 - "Label 1, Label 2"
- Create a smart play-list with conditions: "Matches any: Label + Contains: 'Label 1', Label + Contains: 'Label 2'"
- The third song will show up twice on the playlist.

Expected behavior here is for each song that passes condition one or condition two to show up once.  Songs that path both conditions should only show up once.  However, songs that pass both conditions actually show up two times.

Example 4:
- Create a smart play-list with conditions: "Matches all: Label + Is not 'Label 1', Artist + Is [Some Artist]"
- The smart play-list will only contain the following set of songs:
 - List of all songs with labels, once for each label
 - Remove all songs that have a label matching "Label 1" once for each matching label
 - Remove all songs not by the specified artist.

The expected behavior here is that all songs by the specified artist which do not have a label matching the first condition.  The actual list is only those containing a label which is not label 1.  (Like in example 1, if a song has two labels and one of these is not "Label 1", it will show up on the play-list).