Bug 145848

Summary:	kdebase/workspace/startkde runs dbus-launch --auto-syntax, which gives errors is SHELL is /bin/csh
Product:	[Unmaintained] kstart	Reporter:	Steve Evans <stevee>
Component:	general	Assignee:	Lubos Lunak <l.lunak>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Solaris
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Steve Evans 2007-05-23 14:44:32 UTC

Version:            (using KDE Devel)
Installed from:    Compiled sources
Compiler:          gcc 3.4.6 
OS:                Solaris

(sorry, this bug is in startkde, but bugs.kde.org does not provide that in its list of applications)

startkde calls dbus-launch like this:

eval ` dbus-launch --auto-syntax --exit-with-session < /dev/null`

Unfortunately this gives errors if $SHELL is set to /bin/csh because dbus-launch outputs stuff in CSH syntax.

Changing --auto-syntax into --sh-syntax fixes it. This is in line with the dbus-launch man page that says:

Instead  of  passing  --auto-syntax,  you  may
explicity  specify a particular one by using --sh-syntax for
Bourne syntax, or --csh-syntax for csh syntax.  In  scripts,
it's  more  robust  to avoid --auto-syntax and you hopefully
know which shell your script is written in.

Comment 1 Lubos Lunak 2007-05-24 13:51:37 UTC

SVN commit 667903 by lunakl:

startkde uses /bin/sh, so ask explicitly for sh syntax
when launching dbus (for people not using sh-compatible shell)
BUG: 145848



 M  +1 -1      startkde  


--- trunk/KDE/kdebase/workspace/startkde #667902:667903
@@ -278,7 +278,7 @@
 if ! qdbus >/dev/null 2>/dev/null; then
   # Remove the next two lines after D-Bus 1.0 is released.
   # It comes with auto-starting, so running dbus-launch won't be necessary
-  eval `dbus-launch --auto-syntax --exit-with-session < /dev/null`
+  eval `dbus-launch --sh-syntax --exit-with-session < /dev/null`
   if ! qdbus >/dev/null 2>/dev/null; then
     # Startup error
     echo 'startkde: Could not start D-Bus. Check your installation.'  1>&2