Bug 145771

Summary: Gnome Desktop crashes and restarts when select Cancel option for Mpeg Slideshow tool
Product: [Applications] digikam Reporter: Hubert Furey <hubert.furey>
Component: Plugin-Generic-VideoSlideshowAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: crash CC: caulier.gilles
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: Version Fixed In: 5.7.0

Description Hubert Furey 2007-05-22 02:23:48 UTC 
Version:            (using KDE KDE 3.5.6)
Installed from:    Ubuntu Packages
OS:                Linux

Using Ubuntu 7.04, digikam 0.9.1 , KDE 3.5.6.  The Create MPEG Slideshow plugin causes the desktop to crash and restart, requiring login again.  

Select at least one image and go to Tools > Create MPEG Slideshow.  Video format VCD, video type NTSC Chroma Mode Default.  Click on Encode and get warning dialog that "Check your Mjpegtools version...Default Chroma mode only works with Mjpegtools version < 1.6.3"

Click Cancel to this and desktop crashes and restarts.  Mjpeg tools version 1:1.8.0-0.2ubuntu3 from the Ubuntu packages.
Comment 1 Angelo Naselli 2007-06-03 23:49:45 UTC 
SVN commit 671143 by anaselli:

sigkill wrongly sent to application 
BUG: 145771

 M  +3 -2      kimg2mpg.cpp  


--- branches/extragear/kde3/libs/kipi-plugins/mpegencoder/kimg2mpg.cpp #671142:671143
@@ -703,8 +703,9 @@
   connect(m_Proc, SIGNAL(receivedStderr(KProcess *,char*,int)),this,
           SLOT(readStderr(KProcess*,char*,int)));
 
+  m_Img2mpgPidNum = -1;
   bool result = m_Proc->start(KProcess::NotifyOnExit , KProcess::All);
-
+  
   if(!result)
     {
     QString str = i18n("Cannot start 'images2mpg' bash script : fork failed.");
@@ -998,7 +999,7 @@
   {
   m_Encoding = false;
 
-  if (m_Proc)
+  if (m_Proc && m_Img2mpgPidNum > 0)
     {
         ::kill(m_Img2mpgPidNum, SIGKILL);
     }
Comment 2 caulier.gilles 2017-06-30 07:10:11 UTC 
digiKam has a new Video Slideshow tool based on QtAV and ffmpeg which do not
have this problem.

Gilles Caulier