| Summary: | next torrent from queue is not started when "keep seeding after download is finished is disabled" | ||
|---|---|---|---|
| Product: | [Applications] ktorrent | Reporter: | Christoph Burger-Scheidlin <mail> |
| Component: | general | Assignee: | Ivan Vasic <ivasic> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | mimosius |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | fix queue manager update, if not keep_seeding | ||
QM problem, so Ivan should take a look at it I also noticed this behaviour. The problem seems to be in QueueManager::torrentFinished(). The funtcion returns, when keep_seeding is false and the queue does not get updated. I made a patch, which fixes this in my opinion. Created attachment 20724 [details]
fix queue manager update, if not keep_seeding
SVN commit 670486 by ivasic: Fixed "keed seeding" option. Thanks to Glen Masgai for providing the patch. BUG:145398 M +2 -4 queuemanager.cpp --- trunk/extragear/network/ktorrent/libktorrent/torrent/queuemanager.cpp #670485:670486 @@ -586,11 +586,9 @@ // if(max_seeds !=0 && max_seeds < getNumRunning(false,true)) // tc->stop(true); - if (!keep_seeding) - return; + if (keep_seeding) + torrentAdded(tc, false, false); - torrentAdded(tc, false, false); - orderQueue(); } |
Version: 2.1.4 (using KDE KDE 3.5.6) Installed from: Ubuntu Packages OS: Linux Prerequisites: Maximum Downloads: 5 option "Keep seeding after download is finished" disabled. >5 Torrents in the queue to be downloaded (managed by QM) Observed Behavior: Torrent 6 is not started after Torrent 1 has completed downloading (state transition from downloading -> download completed) Expected Behavior: Torrent 6 starts downloading after Torrent 1 finishes. This correct behavior happens when "keep seeding after download is finished" is enabled (state transition from downloading -> seeding).