| Summary: | sz does not start download wizard | ||
|---|---|---|---|
| Product: | [Applications] konsole | Reporter: | Andreas Schwarz <schwarz_andreas> |
| Component: | general | Assignee: | Konsole Developer <konsole-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ovit.debian |
| Priority: | NOR | ||
| Version: | 1.6.6 | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | Fix for decoding escape chars in the middle of block receives properly | ||
Created attachment 20509 [details]
Fix for decoding escape chars in the middle of block receives properly
*** Bug 147332 has been marked as a duplicate of this bug. *** *** This bug has been confirmed by popular vote. *** Bug still exists in Konsole 1.6.6 (KDE 3.5.7 "release 72.2" openSUSE 10.3) "sz" worked in the past KDE releases, but now it does not. I have been searching Google for a solution to this problem. I have found that many people respond with an answer like "use scp, does anybody use ZModem anymore anyhow?" In case that mindset is influential in the decission to fix this bug I'd like to point out that scp can only make one hop, whereas with SSH I can connect to a computer that has an opening through a firewall, then connect to others that are behind the firewall, then use sz to transfer an individual file, thus it's still very useful. In the meantime I use zssh, but it's less than ideal for other reasons, one of which is that I have to anticipate its need before I connect and make the multiple hops. I totally agree with Rex Kerr. I use zmodem all the time supporting linux servers thru multi-hop ssh connections, and this bug is keeping me away from konqueror. And I am absolutely sure there are many other in this situation. Can the posted patch please be committed to the 3.5 branch? I can confirm it works. I'm updating my 3.5 branch now. 3.5.10 is suppose to come out this month. I'll try to get this patch in for that. I have no way of testing but as long as people using the patch says it works that's fine. SVN commit 846506 by hindenburg: Fix issue with zmodem dialog not popping up. BUG: 145177 M +2 -2 TEmulation.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=846506 |
Version: 1.6.6 (using KDE KDE 3.5.6) Installed from: Gentoo Packages Compiler: gcc 4.1.2 OS: Linux When trying to donwload a file from a host using "sz" the proper escape sequence is displayed but the zmodem download dialog does not pop up. Using echo "" | awk ' { printf("\030B00") } ' causes the dialog to display while echo "" | awk ' { printf("**\030B00") } ' does not. Debugging showed there is a logical error in TEmulation.cpp function TEmulation::onRcvBlk: for(l = i; l < len-1; ++l) if ((unsigned char) s[l] < 32) break; causes an escape char in the middle of a string not to be decoded by the main i loop. Correct code should be: for(l = i; l < len; l++) if ((unsigned char) s[l+1] < 32) break;