Bug 145083

Summary:	Space and Shift-Space isn't used for navigation between images
Product:	[Applications] digikam	Reporter:	Mikolaj Machowski <mikmach>
Component:	Usability-Keyboard	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:	0.9.2
Sentry Crash Report:

Description Mikolaj Machowski 2007-05-05 21:00:12 UTC

Version:            (using KDE Devel)
Installed from:    Compiled sources
OS:                Linux

Space and Shift-Space isn't used for navigation between images.

space should move one image forward
shift-space should move one page backward

Comment 1 caulier.gilles 2007-05-21 10:37:49 UTC

Mik,

SPACE is already defined like a shortcut to Next image action and work very well in editor.

SHIFT+SPACE is not yet defined.

Gilles

Comment 2 caulier.gilles 2007-05-21 10:49:53 UTC

SVN commit 666912 by cgilles:

digikam from trunk : added new accelerator SHIFT+SPACE to go to next image in editor
BUG: 145083

 M  +6 -1      editorwindow.cpp  


--- trunk/extragear/graphics/digikam/utilities/imageeditor/editor/editorwindow.cpp #666911:666912
@@ -476,6 +476,11 @@
                     Key_Space, this, SLOT(slotForward()),
                     false, true);
 
+    d->accelerators->insert("Next Image SHIFT+Key_Space", i18n("Next Image"),
+                    i18n("Load Next Image"),
+                    SHIFT+Key_Space, this, SLOT(slotForward()),
+                    false, true);
+
     d->accelerators->insert("Previous Image Key_Backspace", i18n("Previous Image"),
                     i18n("Load Previous Image"),
                     Key_Backspace, this, SLOT(slotBackward()),
@@ -501,7 +506,7 @@
                     Key_Minus, this, SLOT(slotDecreaseZoom()),
                     false, true);
 
-    d->accelerators->insert("Redo", i18n("Redo"),
+    d->accelerators->insert("Redo CTRL+Key_Y", i18n("Redo"),
                     i18n("Redo Last action"),
                     CTRL+Key_Y, m_canvas, SLOT(slotRedo()),
                     false, true);

Comment 3 Arnd Baecker 2008-04-09 16:40:32 UTC

Mik, Gilles,

triggered by discussion on the IRC I re-read this bug: 
The original wish was: SHIFT+space should go to the previous image.
The patch provides:    SHIFT+space goes      to the next image.

I don't think that this was intended. Reopening bug...

Its trivial to fix, so let me know if I should do so.

Comment 4 Mikolaj Machowski 2008-04-09 17:40:07 UTC

Dnia Wednesday 09 of April 2008, Arnd Baecker napisał:
> I don't think that this was intended. Reopening bug...
>
> Its trivial to fix, so let me know if I should do so.


Yes, please. SHIFT+SPACE combo comes from KDE HIG for keyboard
shortcuts.  digiKam should conform to this spec.

Comment 5 caulier.gilles 2008-04-09 18:17:23 UTC

Arnd,

Fine for me. let's go

Gilles

Comment 6 Arnd Baecker 2008-04-10 10:07:27 UTC

SVN commit 795401 by abaecker:

Use SHIFT+Space to go to the previous image in the image editor.

CCBUGS: 145083
TODO:KDE4PORT



 M  +2 -1      NEWS  
 M  +3 -3      utilities/imageeditor/editor/editorwindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=795401

Comment 7 Arnd Baecker 2008-04-10 10:57:40 UTC

SVN commit 795407 by abaecker:

Use SHIFT+Space to go to the previous image in the light-table. 

CCBUGS: 145083
TODO:KDE4PORT



 M  +5 -0      lighttablewindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=795407

Comment 8 caulier.gilles 2008-04-11 11:59:14 UTC

SVN commit 795744 by cgilles:

backport commits #795407 and #795401 from KDE3 branch
BUG: 145083


 M  +5 -0      imageeditor/editor/editorwindow.cpp  
 M  +5 -0      lighttable/lighttablewindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=795744

Comment 9 Arnd Baecker 2008-04-12 14:23:20 UTC

SVN commit 796052 by abaecker:

Use SHIFT+Space to go to the previous image in the icon view.

CCBUGS: 145083
TODO:KDE4PORT



 M  +3 -3      digikamapp.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=796052