Bug 145077

Summary:	Ctrl-W and Ctrl-Q shortcuts not tied to proper actions
Product:	[Applications] digikam	Reporter:	Mikolaj Machowski <mikmach>
Component:	Usability-Keyboard	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:	0.9.2
Sentry Crash Report:

Description Mikolaj Machowski 2007-05-05 20:42:25 UTC

Version:            (using KDE Devel)
Installed from:    Compiled sources
OS:                Linux

Ctrl-W and Ctrl-Q shortcuts not tied to proper actions

At the moment Ctrl-W calls White Balance plugin and Ctrl-Q closes IE window.

Ctrl-W should close IE window and Ctrl-Q should close *whole* Digikam. IE isn't separate application, only part of Digikam.

Note: Ctrl-W apply to all other windows, LT, imageplugins, etc.

Comment 1 caulier.gilles 2007-05-21 11:01:05 UTC

Mik,

I think than close all digiKam directly from Editor using CTRL+Q can be dangerous.

But i'm agree, File/Quit action must be changed to File/Close to respect std shortcuts.

Gilles

Comment 2 caulier.gilles 2007-05-21 11:03:50 UTC

SVN commit 666916 by cgilles:

digikam from trunk : Image Editor : fix fixed File/Close and File/Quit std actions. Only File/Close action must be available.
BUG: 145077

 M  +2 -2      digikamimagewindowui.rc  
 M  +1 -1      editorwindow.cpp  


--- trunk/extragear/graphics/digikam/utilities/imageeditor/editor/digikamimagewindowui.rc #666915:666916
@@ -1,5 +1,5 @@
 <!DOCTYPE kpartgui SYSTEM "kpartgui.dtd">
-<gui version="16" name="digikamimagewindow" >
+<gui version="17" name="digikamimagewindow" >
 
 <MenuBar>
 
@@ -18,7 +18,7 @@
         <Separator/>
         <Action name="editorwindow_delete" />
         <Separator/>
-        <Action name="editorwindow_exit" />
+        <Action name="editorwindow_close" />
     </Menu>
     
     <Menu name="Edit" ><text>&amp;Edit</text>
--- trunk/extragear/graphics/digikam/utilities/imageeditor/editor/editorwindow.cpp #666915:666916
@@ -284,7 +284,7 @@
                                      this, SLOT(slotDeleteCurrentItem()),
                                      actionCollection(), "editorwindow_delete");
 
-    KStdAction::quit(this, SLOT(close()), actionCollection(), "editorwindow_exit");
+    KStdAction::close(this, SLOT(close()), actionCollection(), "editorwindow_close");
 
     // -- Standard 'Edit' menu actions ---------------------------------------------

Comment 3 caulier.gilles 2007-05-21 11:04:14 UTC

SVN commit 666917 by cgilles:

digikam from trunk : Showfoto : fix fixed File/Close and File/Quit std actions. Only File/Close action must be available.
CCBUGS: 145077

 M  +2 -2      showfotoui.rc  


--- trunk/extragear/graphics/digikam/showfoto/showfotoui.rc #666916:666917
@@ -1,5 +1,5 @@
 <!DOCTYPE kpartgui SYSTEM "kpartgui.dtd">
-<gui version="20" name="showfoto" >
+<gui version="21" name="showfoto" >
 
 <MenuBar>
 
@@ -21,7 +21,7 @@
         <Separator/>
         <Action name="editorwindow_delete" />
         <Separator/>
-        <Action name="editorwindow_exit" />     
+        <Action name="editorwindow_close" />     
     </Menu>
 
     <Menu name="Edit" ><text>&amp;Edit</text>

Comment 4 caulier.gilles 2007-05-21 11:05:37 UTC

SVN commit 666918 by cgilles:

digikam from trunk : Light Table : fix fixed File/Close and File/Quit std actions. Only File/Close action must be available.
CCBUGS: 145077

 M  +1 -1      lighttablewindow.cpp  
 M  +2 -2      lighttablewindowui.rc  


--- trunk/extragear/graphics/digikam/utilities/lighttable/lighttablewindow.cpp #666917:666918
@@ -358,7 +358,7 @@
                                      actionCollection(), "lighttable_filedelete");
     d->fileDeleteAction->setEnabled(false);
 
-    KStdAction::quit(this, SLOT(close()), actionCollection(), "lighttable_exit");
+    KStdAction::close(this, SLOT(close()), actionCollection(), "lighttable_close");
 
     // -- Standard 'View' menu actions ---------------------------------------------
 
--- trunk/extragear/graphics/digikam/utilities/lighttable/lighttablewindowui.rc #666917:666918
@@ -1,5 +1,5 @@
 <!DOCTYPE kpartgui SYSTEM "kpartgui.dtd">
-<gui version="17" name="lighttablewindow" >
+<gui version="18" name="lighttablewindow" >
 
 <MenuBar>
 
@@ -18,7 +18,7 @@
         <Separator/>
         <Action name="lighttable_filedelete" />
         <Separator/>
-        <Action name="lighttable_exit" />
+        <Action name="lighttable_close" />
     </Menu>
     
     <Menu name="View" ><text>&amp;View</text>

Comment 5 caulier.gilles 2007-05-21 11:54:27 UTC

SVN commit 666927 by cgilles:

digiKam from trunk : White Balance tool : use CTRL+SHIFT+W instead CTRL+W to prevent conflict with std KDE shortcuts
CCBUGS: 145077

 M  +1 -1      imageplugin_whitebalance.cpp  


--- trunk/extragear/graphics/digikam/imageplugins/whitebalance/imageplugin_whitebalance.cpp #666926:666927
@@ -40,7 +40,7 @@
                         : Digikam::ImagePlugin(parent, "ImagePlugin_WhiteBalance")
 {
     m_whitebalanceAction = new KAction(i18n("White Balance..."), "whitebalance", 
-                               CTRL+Key_W, 
+                               CTRL+SHIFT+Key_W, 
                                this, SLOT(slotWhiteBalance()),
                                actionCollection(), "imageplugin_whitebalance");