| Summary: | Crash on exit when using fits based data source | ||
|---|---|---|---|
| Product: | [Applications] kst | Reporter: | Netterfield <netterfield> |
| Component: | general | Assignee: | kst |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | ||
| Priority: | NOR | ||
| Version: | 1.x | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
backtrace from the crash
145050.badpatch patch_tsk_20070505_healpix_metadata |
||
|
Description
Netterfield
2007-05-04 22:06:46 UTC
Created attachment 20485 [details]
backtrace from the crash
Here is a patch which stops the crash by removing the removal of metadata strings from the destructor. This could be thought of as a clue more than a patch. This bug is important for 1.4.0. Eli? Created an attachment (id=20487) 145050.badpatch I have confirmed that the attached patch, which disables populating the metadata, fixes the crash for the healpix datasource. This is probably cleaner than disabling the destruction of all metadata. I do not know if this problem arises from other datasources that populate the metadata... -Ted On Friday 04 May 2007 23:58, Barth Netterfield wrote: > Here is a patch which stops the crash by removing the removal of metadata > strings from the destructor. > > This could be thought of as a clue more than a patch. > > This bug is important for 1.4.0. > > Eli? Created an attachment (id=20490) patch_tsk_20070505_healpix_metadata On 5-May-07, at 2:58 AM, Barth Netterfield wrote: > Here is a patch which stops the crash by removing the removal of > metadata > strings from the destructor. > > This could be thought of as a clue more than a patch. > > This bug is important for 1.4.0. We have to figure out why it's crashing. I don't think we can just leave them in there. I will investigate shortly. -- George Staikos KDE Developer http://www.kde.org/ Staikos Computing Services Inc. http://www.staikos.net/ SVN commit 662516 by staikos:
Another case of variable declarations in the wrong place causing subtle bugs.
If the object lives beyond the scope it was supposed to be in we end up with
an object destruction order problem.
BUG: 145050
M +1 -2 main.cpp
--- trunk/extragear/graphics/kst/src/kst/main.cpp #662515:662516
@@ -382,7 +382,6 @@
KstApp *kst = new KstApp;
InType in;
QColor color;
- KstDataSourcePtr file;
QCStringList ycolList;
QCStringList matrixList;
QCStringList yEqList;
@@ -514,7 +513,7 @@
} else {
fullPath = args->arg(i_file);
}
- file = KstDataSource::loadSource(fullPath);
+ KstDataSourcePtr file = KstDataSource::loadSource(fullPath);
if (file) {
if (!file->isValid() || file->isEmpty()) {
kstdError() << i18n("No data in file %1. Trying to continue...").arg(args->arg(i_file)) << endl;
SVN commit 662612 by arwalker:
CCBUG:145050 Forward port from 1.4
M +3 -2 main.cpp
--- branches/work/kst/1.5/kst/src/kst/main.cpp #662611:662612
@@ -383,7 +383,6 @@
KstApp *kst = new KstApp;
InType in;
QColor color;
- KstDataSourcePtr file;
QCStringList ycolList;
QCStringList matrixList;
QCStringList yEqList;
@@ -517,7 +516,9 @@
} else {
fullPath = args->arg(i_file);
}
- file = KstDataSource::loadSource(fullPath);
+
+ KstDataSourcePtr file = KstDataSource::loadSource(fullPath);
+
if (file) {
if (!file->isValid() || file->isEmpty()) {
kstdError() << i18n("No data in file %1. Trying to continue...").arg(args->arg(i_file)) << endl;
|