Bug 144815

Summary:	wish: scroll left-pane to the selected album/date on start-up
Product:	[Applications] digikam	Reporter:	S. Burmeister <sven.burmeister>
Component:	Albums-TreeView	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	caulier.gilles
Priority:	NOR
Version:	0.9.1
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:		Version Fixed In:	0.9.3
Sentry Crash Report:
Attachments:	make selected folder visible

Description S. Burmeister 2007-04-29 09:09:15 UTC

Version:           0.9.1 (using KDE KDE 3.5.5)
Installed from:    SuSE RPMs
OS:                Linux

Digikam remembers the last selected album/date on exit and opens that view and selection when starting up again.

However the selected album/view is not visible in the left pane, since in album view it is always scrolled to the top and in date-view always at the bottom of the album-/date-list.

Expected behaviour: scroll the left pane on starting up to make the current selection visible to the user.

I am not sure whether the selected album/date should be the first visible entry in the left pane or somewhere in the middle.

Comment 1 Arnd Baecker 2007-04-30 13:56:15 UTC

Somewhere inthe middle might be better to see the context.

Also: remembering the selected image (and moving to that) might
be nice as well.

Comment 2 Arnd Baecker 2007-07-02 01:57:17 UTC

I don't observe the problem you describe for the album view, 
but for the tags view and  the date  view.

Comment 3 Arnd Baecker 2007-09-08 10:52:48 UTC

Hmm, on a re-check I also observe it for the album view.
Interestingly, in principle the code is there to make it work in 
the first place:
In  folderview.cpp, in the routine void FolderView::loadViewState()
one finds 
   ensureItemVisible(item);
So this should work.
Is this another example of a race condition, where this call
comes to early?

Comment 4 Arnd Baecker 2007-09-10 08:19:18 UTC

Created attachment 21582 [details]
make selected folder visible

The origin of this bug is that setting the visibility does
not seem to have any effect when this is done in a loop
where folders are opened. 
(Big thanks to Marcel!)

Comment 5 Arnd Baecker 2007-09-10 08:31:01 UTC

I would like to extend this patch a little bit more so that
also the last viewed image is saved and that the corresponding
icon will be shown.
Does that sound useful?

Note that this should be very easy to do via
the d->itemUrlToFind mechanism, if the problem
(race condition?) described in the patch for
http://bugs.kde.org/show_bug.cgi?id=96894
is solved.

Comment 6 Arnd Baecker 2007-10-19 11:55:40 UTC

Hmm, maybe it is better to apply this patch first
(it might take too long until I have time to tackle the additional feature 
and delay this ...)

Comment 7 Arnd Baecker 2007-10-30 09:10:32 UTC

SVN commit 730938 by abaecker:

Scroll the left panel on start up to so that the current selection is visible.

CCBUGS: 144815
TODO:KDE4PORT



 M  +2 -1      NEWS  
 M  +10 -2     digikam/folderview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=730938

Comment 8 caulier.gilles 2007-10-30 09:24:45 UTC

SVN commit 730946 by cgilles:

backport commit #730938 to KDE4
BUG: 144815


 M  +17 -4     folderview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=730946