Summary: | "Force input charset" fundamentally broken | ||
---|---|---|---|
Product: | [Applications] k3b | Reporter: | Egmont Koblinger <egmont> |
Component: | Data Project | Assignee: | Sebastian Trueg <trueg> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
Egmont Koblinger
2007-04-23 15:14:29 UTC
The "enforce charset" option was introduced way back when K3b had no charset check yet. So yes, it is probably outdated and pretty useless as such ATM. However, I will not start implementing support for different filename encodings in K3b. Do you have any idea what a mess that is? And how do you propose that the GUI would handle that? Ask for each file which charset is to be used? Or have an additional charset parameter in K3b although this should be set system wide? Because in the end the proper filename encoding handling is the job of the operating system or more specific the filesystem. Internally K3b (since it is QT/KDE) only uses UTF8 anyway. The problems start when passing the filenames on to mkisofs/genisoimage. This is where the local encoding is used and only that. So on a properly configured system no problems should arise. I also do not really see why you would have different filename encodings in your system. Again, the current force charset option is useless and I will probably remove it. > So on a properly configured system no problems should arise. I agree. > I also do not really see why you would have different filename encodings in your system. Possible reasons include data downloaded from remote server with wget/rsync/..., or a mounted rockridge CD that you've burnt ages ago with legacy filename charsets. However, I agree that it's not k3b's job to fix those situations, rather convmv should be used, the kernel should be able to convert charset of rockridge iso's etc... > I will probably remove it. Sounds fine, thanks. SVN commit 659528 by trueg: Removed the "force input charset" option from K3b. Now that K3b checks the filename encoding this option can only be used to break stuff and, thus, is useless. BUG: 144566 M +0 -14 libk3b/projects/datacd/k3bdatadoc.cpp M +0 -3 libk3b/projects/datacd/k3bisoimager.cpp M +0 -10 libk3b/projects/datacd/k3bisooptions.cpp M +0 -7 libk3b/projects/datacd/k3bisooptions.h M +12 -40 src/projects/base_k3badvanceddataimagesettings.ui M +28 -80 src/projects/k3bdataadvancedimagesettingswidget.cpp M +7 -9 src/projects/k3bdataimagesettingswidget.cpp |