| Summary: | In Caption/Tags sidebar, new Tags inherit the image of their parents | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Dotan Cohen <kde-2011.08> |
| Component: | Tags-Captions | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles, dch.code, kde-2011.08, laurakittyinka, metzpinguin, timetre |
| Priority: | NOR | ||
| Version: | 4.1.0 | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/graphics/digikam/-/commit/087bdcd4c244e5acd5552c8b08e8636dc92ca31f | Version Fixed In: | 7.2.0 |
| Sentry Crash Report: | |||
|
Description
Dotan Cohen
2007-04-13 14:56:52 UTC
Yes, I think this should be improved... I can confirm this, too. I also would prefer an empty icon, but there might also be users who want to have the icon of the parent set for the child tag. We need to discuss this. Any suggestions here? > We need to discuss this. Any suggestions here?
An option. It could either be a general option for all of digikam, or a checkbox for each tag whether or not new child tabs get an empty icon or their parent's icon.
Dotan, This file still valid using digiKam 2.4 ? Gilles Caulier Yes, still valid. Steps to reproduce: 1) Assign an an icon/image to a tag. 2) Right-click the tag, select New Tag. 3) Finish creating the new tag, do not assign an image. Notice that the icon/image of the new tag is the icon/image of the parent tag. Dotan, This file still valid using last digiKam 4.2.0 ? Gilles Caulier The issue is still valid in Digikam 4.1, using the steps to reproduce from Comment #5. This problem still valid using last digiKam 5.0.0 ? Gilles Caulier Any feedback with current AppImage bundle for Linux ? https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM Gilles Caulier I support the proposal of Dotan Cohen to have an option whether the new tag should inherit the icon or not, because the first can save you the hassle of finding a particular tag in lenghty tables/lists. I even "abuse" this function if I want the same icon for a tag that is not a child. I first create the new tag as a child and then move it to somewhere eles in the tree. I think there may be a simple fix for this, that might allow us to close this very old report. At the moment, if the user wishes to use the standard icon, the tag has to be first created with right click then 'New Tag'. Then right click on the new tag then either 'Reset Tag Icon', or 'Properties' then 'Reset'. If we put a Reset button on the 'New Tag' popup dialog, then the user may choose the standard icon at creation time saving a few clicks. The 'New Tag' popup and the 'Properties' popup share the same dialog code (core/libs/tags/widgets/tageditdlg.cpp), so it is a simple fix to remove the code that disables the button. I'll send a merge request shortly. Fixed with this commit: https://invent.kde.org/graphics/digikam/-/commit/087bdcd4c244e5acd5552c8b08e8636dc92ca31f Maik |