Bug 143716

Summary:	scripts packages are incorrectly uninstalled
Product:	[Applications] amarok	Reporter:	Sergio Pistone <sergio_pistone>
Component:	Tools/Script Manager	Assignee:	Amarok Developers <amarok-bugs-dist>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	1.4.5
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	scriptmanager.cpp patch (works with 1.4.5 and current svn)

Description Sergio Pistone 2007-04-02 07:26:04 UTC

Version:           1.4.5 (using KDE KDE 3.5.6)
Installed from:    Gentoo Packages
OS:                Linux

when uninstalling scripts, only the directory containing the executable gets removed, leaving part of the script package's files if said executable was not on the script root folder (check what happens when removing wiki-lyrics v0.10 to see what i'm talking about).
to correctly remove a script, the whole tree belonging to it's package should be be removed from the scripts directory.

Comment 1 Sergio Pistone 2007-04-13 21:44:10 UTC

Created attachment 20266 [details]
scriptmanager.cpp patch (works with 1.4.5 and current svn)

patch to fix the uninstalling of scripts (remove the whole script package tree,
not just the directory containing the executable)

Comment 2 Wayno 2007-06-01 23:18:40 UTC

This bug is reproduceamble at will.  What happens is when a script is removed, it is NOT deleted.  So when you try to re-install it, it says the script is already installed, even though the script does NOT show up on the installed script list.

files (scripts) should be deleted from 


/home/<useridgoeshere>/.kde/share/apps/amarok/scripts-data/<nameofscript.xml>

and  
/home/<useridgoeshere>/.kde/share/apps/amarok/scripts/<nameofscript.xml>

Wayno

Comment 3 Mark Kretschmann 2007-06-02 10:35:37 UTC

Patch committed in r670627. Thanks Sergio!