Bug 143519

Created attachment 20110 [details]
automatic backtrack of the crash

SVN commit 657339 by tbraun:

remove our own "not perfectly" working spellchecker implementation, now the katepart spellchecker is always in charge.
It has proven to be more reliable.

Therefore I can happily close the following bugs:
BUG: 114226
BUG: 116677
BUG: 70592
BUG: 70592
BUG: 143366
BUG: 143519
BUG: 141386

For a better spellchecked future :)


 M  +21 -21    Makefile.am  
 M  +0 -6      kile.cpp  
 M  +1 -3      kile.h  
 D             kilespell.cpp  
 D             kilespell.h  
 D             kilespell2.cpp  
 D             kilespell2.h  
 M  +0 -8      kileviewmanager.cpp  
 M  +0 -1      kileviewmanager.h  


--- trunk/extragear/office/kile/kile/Makefile.am #657338:657339
@@ -7,26 +7,26 @@
 kile_SOURCES = latexcmd.cpp latexcmddialog.cpp texdocdialog.cpp userhelp.cpp \
 	userhelpdialog.cpp floatdialog.cpp mathenvdialog.cpp tabulardialog.cpp \
 	postscriptdialog.cpp previewconfigwidget.cpp quickpreview.cpp includegraphicsdialog.cpp \
-	newfilewizard.cpp managetemplatesdialog.cpp templates.cpp \
-	usermenudialog.cpp kileconfigdialog.cpp tabbingdialog.cpp symbolview.cpp \
-	quickdocumentdialog.cpp kilefileselect.cpp kileapplication.cpp docpart.cpp kile.cpp main.cpp \
-	kileactions.cpp kilestdactions.cpp kileinfo.cpp kiledocumentinfo.cpp kileproject.cpp \
-	kileprojectdlgs.cpp kileprojectview.cpp kilelistselector.cpp kilelyxserver.cpp \
-	latexoutputfilter.cpp outputinfo.cpp latexoutputinfo.cpp outputfilter.cpp kilegrepdialog.cpp \
-	kiletool.cpp kilelauncher.cpp kiletoolmanager.cpp kilestdtools.cpp kilelogwidget.cpp \
+	newfilewizard.cpp managetemplatesdialog.cpp templates.cpp usermenudialog.cpp \
+	kileconfigdialog.cpp tabbingdialog.cpp symbolview.cpp quickdocumentdialog.cpp \
+	kilefileselect.cpp kileapplication.cpp docpart.cpp kile.cpp main.cpp kileactions.cpp \
+	kilestdactions.cpp kileinfo.cpp kiledocumentinfo.cpp kileproject.cpp kileprojectdlgs.cpp \
+	kileprojectview.cpp kilelistselector.cpp kilelyxserver.cpp latexoutputfilter.cpp \
+	outputinfo.cpp latexoutputinfo.cpp outputfilter.cpp kilegrepdialog.cpp kiletool.cpp \
+	kilelauncher.cpp kiletoolmanager.cpp kilestdtools.cpp kilelogwidget.cpp \
 	kileoutputwidget.cpp kilekonsolewidget.cpp kilewizard.cpp kilestructurewidget.cpp \
 	codecompletion.cpp configcodecompletion.cpp kiletoolconfigwidget.cpp kileedit.cpp \
 	cleandialog.cpp kilehelp.cpp configstructure.cpp kileappIface.skel convert.cpp \
 	helpconfigwidget.ui kiledocmanager.cpp kileviewmanager.cpp kileeventfilter.cpp \
-	latexconfigwidget.ui kileconfig.kcfgc generalconfigwidget.ui kilespell.cpp \
-	kileerrorhandler.cpp configcheckerdlg.cpp configcheckerwidget.ui configtester.cpp \
-	kilesidebar.cpp toolconfigwidget.ui librarytoolconfigwidget.ui \
-	processtoolconfigwidget.ui quicktoolconfigwidget.ui plaintolatexconverter.cpp \
-	latextoolconfigwidget.ui newtoolwizard.ui kileuntitled.cpp \
-	kilestatsdlg.cpp kilestatswidget.cpp envconfigwidget.ui structureconfigwidget.ui \
-	previewwidget.cpp kilejscript.h kilejscript.cpp scriptsmanagementwidget.h scriptsmanagementwidget.cpp \
-	editorkeysequencemanager.h editorkeysequencemanager.cpp scriptingconfigwidget.ui \
-	kileabbrevview.cpp kileextensions.cpp kileversion.cpp graphicsconfigwidget.ui kilemultitabbar.cpp
+	latexconfigwidget.ui kileconfig.kcfgc generalconfigwidget.ui kileerrorhandler.cpp \
+	configcheckerdlg.cpp configcheckerwidget.ui configtester.cpp kilesidebar.cpp \
+	toolconfigwidget.ui librarytoolconfigwidget.ui processtoolconfigwidget.ui \
+	quicktoolconfigwidget.ui plaintolatexconverter.cpp latextoolconfigwidget.ui newtoolwizard.ui \
+	kileuntitled.cpp kilestatsdlg.cpp kilestatswidget.cpp envconfigwidget.ui \
+	structureconfigwidget.ui previewwidget.cpp kilejscript.h kilejscript.cpp \
+	scriptsmanagementwidget.h scriptsmanagementwidget.cpp editorkeysequencemanager.h \
+	editorkeysequencemanager.cpp scriptingconfigwidget.ui kileabbrevview.cpp kileextensions.cpp \
+	kileversion.cpp graphicsconfigwidget.ui kilemultitabbar.cpp
 
 kile_LDADD   = -lkjs -lkdeprint -lktexteditor -lkatepartinterfaces $(LIB_KSPELL) $(LIB_KHTML) 
 
@@ -95,11 +95,11 @@
 
 syntaxdir = $(kde_appsdir)/katepart/syntax
 noinst_HEADERS = kiletool.h kilelauncher.h kiletool_enums.h kiletoolmanager.h \
-		kilestdtools.h kilelogwidget.h kileoutputwidget.h kilekonsolewidget.h kilewizard.h \
-		kilestructurewidget.h convert.h kiledocmanager.h kileviewmanager.h kileeventfilter.h \
-		latexconfigwidget.h kilespell.h kileerrorhandler.h configcheckerdlg.h configtester.h \
-		kilesidebar.h plaintolatexconverter.h kileuntitled.h 	kilestatsdlg.h \
-	kilestatswidget.h envconfigwidget.h structureconfigwidget.h kileversion.h kileconstants.h kilemultitabbar.h  kilemultitabbar_p.h
+	kilestdtools.h kilelogwidget.h kileoutputwidget.h kilekonsolewidget.h kilewizard.h \
+	kilestructurewidget.h convert.h kiledocmanager.h kileviewmanager.h kileeventfilter.h \
+	latexconfigwidget.h kileerrorhandler.h configcheckerdlg.h configtester.h kilesidebar.h \
+	plaintolatexconverter.h kileuntitled.h 	kilestatsdlg.h kilestatswidget.h envconfigwidget.h \
+	structureconfigwidget.h kileversion.h kileconstants.h kilemultitabbar.h kilemultitabbar_p.h
 
 CREATE_HASH_TABLE = $(top_srcdir)/kile/kile/create_hash_table
 
--- trunk/extragear/office/kile/kile/kile.cpp #657338:657339
@@ -70,8 +70,6 @@
 #include "kileconfig.h"
 #include "kileerrorhandler.h"
 #include "configcheckerdlg.h"
-#include "kilespell.h"
-//#include "kilespell2.h"
 #include "kilesidebar.h"
 #include "symbolview.h"
 #include "floatdialog.h"
@@ -113,7 +111,6 @@
 	m_partManager = new KParts::PartManager( this );
 	m_eventFilter = new KileEventFilter(m_edit);
 	m_errorHandler = new KileErrorHandler(this, this);
-	m_spell = new KileSpell(this, this, "kilespell");
 	m_quickPreview = new KileTool::QuickPreview(this);
 	m_extensions = new KileDocument::Extensions();
 
@@ -500,9 +497,6 @@
 
 	(void) new KAction(i18n("Find &in Files..."), "filegrep", ALT+SHIFT+Key_F, this, SLOT(findInFiles()), actionCollection(),"FindInFiles" );
 
-	kdDebug() << "CONNECTING SPELLCHECKER" << endl;
-	connect ( viewManager(), SIGNAL(startSpellCheck()), m_spell, SLOT(spellcheck()) );
-
 	(void) new KAction(i18n("Refresh Str&ucture"), "refreshstructure", Key_F12, this, SLOT(refreshStructure()), actionCollection(),"RefreshStructure" );
 
 	//project actions
--- trunk/extragear/office/kile/kile/kile.h #657338:657339
@@ -71,7 +71,6 @@
 class KileProjectView;
 class TemplateItem;
 class KileAutoSaveJob;
-class KileSpell;
 class KileErrorHandler;
 class KileSideBar;
 
@@ -322,8 +321,7 @@
 			
 private:
 	KileErrorHandler 	*m_errorHandler;
-	KileSpell			*m_spell;
-	
+ 	
 // QuickPreview
 private slots:
 	void slotQuickPreview(int type);
--- trunk/extragear/office/kile/kile/kileviewmanager.cpp #657338:657339
@@ -146,14 +146,6 @@
 	connect( view, SIGNAL(completionAborted()), m_ki->editorExtension()->complete(),  SLOT( slotCompletionAborted()) );
 	connect( view, SIGNAL(filterInsertString(KTextEditor::CompletionEntry*,QString *)), m_ki->editorExtension()->complete(),  SLOT(slotFilterCompletion(KTextEditor::CompletionEntry*,QString *)) );
 
-	KAction *spa = view->actionCollection()->action( "tools_spelling" );
-	if ( spa )
-	{
-		kdDebug() << "RECONNECTING SPELLCHECKER" << endl;
-		disconnect(spa , 0 , 0 , 0);
-		connect( spa, SIGNAL(activated()), this, SIGNAL(startSpellCheck()) );
-	}
-
 	// install a working kate part popup dialog thingy
 	QPopupMenu *viewPopupMenu = (QPopupMenu*)(m_client->factory()->container("ktexteditor_popup", m_client));
 	if((NULL != view) && (NULL != viewPopupMenu))
--- trunk/extragear/office/kile/kile/kileviewmanager.h #657338:657339
@@ -108,7 +108,6 @@
 signals:
 	void activateView(QWidget *, bool);
 	void prepareForPart(const QString &);
-	void startSpellCheck();
 	void startQuickPreview(int);
 
 private: