Bug 143352

Summary:	JavaScript console not usable
Product:	[Applications] kst	Reporter:	Andrew Walker <arwalker>
Component:	general	Assignee:	kst
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	1.x
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Andrew Walker 2007-03-22 18:47:40 UTC

Version:           HEAD (using KDE KDE 3.5.1)
Installed from:    Compiled From Sources
OS:                Linux

PROBLEM:

At present the JavaScript console is not usable due to the presence of default shortcuts for the data wizard (W) and 2D plot(2)

STEPS TO REPRODUCE;

Start Kst
Enable the JavaScript extension if necessary
Select Tools... Show JavaScript Console
Enter a command

RESULTS:

Any command that uses 'W' or '2' will launch the associated shortcut

EXPECTED RESULTS:

No shortcut should be launched when typing into the JavaScript console

Comment 1 Andrew Walker 2007-03-22 18:49:15 UTC

It probably makes most sense not to use shortcuts which are a single alphanumeric key (W and 2).

Though this still does not save the user from themselves if they were to create such shortcuts on their own.

Comment 2 Netterfield 2007-03-28 23:26:35 UTC

I confirm this bug.

Comment 3 George Staikos 2007-03-29 20:29:44 UTC

One-key shortcuts are actually generally against KDE UI policy (see  
KMail changes).  I could switch them to CTRL+ALT+W and CTRL+2.   
Shortcuts will always trigger top-level so changing the keys is the  
only choice.
--
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/

Comment 4 George Staikos 2007-03-30 20:03:28 UTC

SVN commit 648184 by staikos:

Choose non-1-character key shortcuts
Reviewed by Barth.
BUG: 143352


 M  +2 -2      kst.cpp  


--- trunk/extragear/graphics/kst/src/libkstapp/kst.cpp #648183:648184
@@ -733,7 +733,7 @@
 
   /************/
   DataWizardAction = new KAction(i18n("Data &Wizard"), "wizard", 
-                                 KShortcut(Key_W),
+                                 KShortcut(CTRL+ALT+Key_W),
                                  this, SLOT(showDataWizard()),
                                  actionCollection(), "datawizard_action");
   DataWizardAction->setWhatsThis(i18n("Bring up a wizard\n"
@@ -791,7 +791,7 @@
   _gfxPictureAction->setWhatsThis(i18n("Insert picture"));
   
   _gfx2DPlotAction = new KRadioAction(i18n("&2DPlot"), "kst_newplot",
-                                   KShortcut(Key_2),
+                                   KShortcut(CTRL+Key_2),
                                    this, SLOT(toggleMouseMode()),
                                    actionCollection(), "2dplot_action");
   _gfx2DPlotAction->setExclusiveGroup("gfx");