| Summary: | Record parent todo's when recording completed todo to journal. | ||
|---|---|---|---|
| Product: | [Applications] korganizer | Reporter: | Jesse Merriman <jessemerriman> |
| Component: | todoview | Assignee: | kdepim bugs <kdepim-bugs> |
| Status: | REPORTED --- | ||
| Severity: | wishlist | CC: | h.saal |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Attachments: |
Patch against calendarview.h from 3.3.5
Patch against calendarview.cpp from 3.3.5 UNTESTED patch against trunk's calendarview.h UNTESTED patch against trunk's calendarview.cpp Nicer patch against calendarview.cpp from trunk Nicer patch against calendarview.cpp from 3.3.5 Even nicer patch against calendarview.cpp from 3.3.5 Hopefully last version of patch against calendarview.cpp 3.3.5 |
||
Created attachment 20046 [details]
Patch against calendarview.h from 3.3.5
Created attachment 20047 [details]
Patch against calendarview.cpp from 3.3.5
I've tested this and the calendarview.h 3.3.5 patch.
Created attachment 20048 [details]
UNTESTED patch against trunk's calendarview.h
Untested patch against revision 627512 of calendarview.h
Sorry its untested, but I figure it might be helpful and is better than
nothing.
Created attachment 20049 [details]
UNTESTED patch against trunk's calendarview.cpp
Untested patch against revision 640714 of calendarview.cpp
See my comment from the previous patch..
I've been testing only with 3.3.5, since I happened to have a source tarball for that at hand. The trunk patches I posted are just copy-paste jobs that were not tested. I have done very little KDE or QT coding, so be extra-critical of this code. Particularly I am unsure if the internationalization is OK (eg right-to-left languages and the indentation,...). Created attachment 20050 [details]
Nicer patch against calendarview.cpp from trunk
Ack, the first version of this patch was producing excess newlines. This fixes
that.
Created attachment 20051 [details]
Nicer patch against calendarview.cpp from 3.3.5
Again, removes an excess newline.
Created attachment 20052 [details]
Even nicer patch against calendarview.cpp from 3.3.5
Fixes one small code screw-up in the previous version of this patch.
Created attachment 20053 [details]
Hopefully last version of patch against calendarview.cpp 3.3.5
Dammit. I should not be doing this while so tired.. Anyway, the previous
version of this patch was in the wrong order (new->old), here is how it should
be. I won't be submitting any more tonight, I promise.
*** Bug 144927 has been marked as a duplicate of this bug. *** |
Version: 3.5.5 (using KDE KDE 3.5.5) Installed from: Gentoo Packages OS: Linux When a completed todo is set to automatically add a journal entry, only that todo's summary is recorded. Often this doesn't give me enough information, and I need to know its parents to fully identify it, especially in cases where different parent-todos each have identically-named children, as so: Foo +- x Bar +- x Right now, completing Foo/x would result in this journal entry: To-do completed: x (08:46 pm) This does not tell me whether it refers to Foo/x or Bar/x. I propose that it should show the complete hierarchy, like this: To-do completed at 08:46 pm: Foo x I've written a patch that does just that. PS: this is similar to bug 81910.