Summary: | Non multipart MIME mails containing only a single attachment fail | ||
---|---|---|---|
Product: | [Unmaintained] kmail | Reporter: | Hans-Peter Jansen <hpj> |
Component: | mime | Assignee: | kdepim bugs <kdepim-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | djander, jean.robertson, mi+kde, neale, wbsoft, wstephenson |
Priority: | NOR | ||
Version: | 1.9.5 | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: | |||
Attachments: |
send non multipart MIME mail containing a single attachment
small test pdf to play with.. My bad email gzipped email that demonstrates the bug |
Description
Hans-Peter Jansen
2007-03-19 21:30:12 UTC
Created attachment 20040 [details]
send non multipart MIME mail containing a single attachment
Created attachment 20041 [details]
small test pdf to play with..
Is this the same as bug 113516 maybe? Actually, it could also be the same as bug 142068. What happens if you save the attachment? Does it get truncated? Does the message have the attachment flag in the message list? Hi Thomas, thanks for caring. > Is this the same as bug 113516 maybe? > Actually, it could also be the same as bug 142068. Yes, basically they're all the same problem! Sorry for not querying the problem exhaustively enough... > What happens if you save the attachment? Does it get truncated? Well, it's not truncated, it's way shorter than the original, but it's distorted, üzgül so to say: -rw------- 1 hp site 365 20. Mär 15:23 tmp/MIMEmailwithsingle attachment.pdf -rw-rw-r-- 1 hp site 8989 19. Mär 21:32 tmp/testa.pdf > Does the message have the attachment flag in the message list? No. This report has some advantages over the others, since it's formulated more general, tells a workaround, which will do for the others guys in the meantime, with the plus to being able to reproduce it with minimum effort. I'm sure, it gives a kmail developer enough hints to finally fix this ugly issue.. Thus I vote for "duplicating" the others. From my POV, it's the most annoying issue with kmail in enterprise environments ATM. >Hi Thomas, thanks for caring. Don't get your hopes up, I'm just trying to make sure incoming bugs are no duplicates. I am not a KMail developer myself. >This report has some advantages over the others, since it's formulated more general, tells a workaround, which will do for the others guys in the meantime, with the plus to being able to reproduce it with minimum effort. I'm sure, it gives a kmail developer enough hints to finally fix this ugly issue.. Thus I vote for "duplicating" the others. OK, I'll close them as duplicates. *** Bug 142068 has been marked as a duplicate of this bug. *** *** Bug 113516 has been marked as a duplicate of this bug. *** There is a test mail available at http://woozle.org/~neale/tmp/T-Board Agenda for March 1 Meeting (from one of the dupliate reports). However, I can not reproduce the problem with that mail (I saved it as text file and put it in my inbox folder). Saving and opening it with OOO from within KMail worked fine. Created attachment 20058 [details]
My bad email
This is probably less useful than the python script, but here's the email that
caused problems for me. It will be removed from my web server soon.
>> Hi Thomas, thanks for caring. > Don't get your hopes up, I'm just trying to make sure incoming bugs are no > duplicates. I am not a KMail developer myself. Yup, I know, since I cursory follow kde-pim ML. They seem busy with kde4 stuff all the time. But nevertheless, you're doing something important for this great MUA and its developers. Hopefully, somebody will pick it up one day. > This is probably less useful than the python script Did someone from the kind audience tried to reproduce it with the script? Sure, I did, but I'm awaiting confirmation since I put this bug into SUSE bugzilla #120238, exactly one month ago :-( Needless to say, I haven't got a single reply there, that's why I'm here.. *** Bug 143490 has been marked as a duplicate of this bug. *** *** Bug 144609 has been marked as a duplicate of this bug. *** The reporter in bug 144609 says that turning off "load attachments on demand" works around this problem. So maybe this is only a problem for IMAP accounts. This was indeed the case. Fixed by commit r653900 >Fixed by commit r653900 Really? looks like a different thing to me: >SVN commit 653900 by wstephens: >Allow the user to cancel kmail connection attempts when the account >settings are incorrect (Novell bug 247903). >BUG:93199 SVN commit 659645 by wstephens: Add comment so that posterity can see that r653900 actually solved bug #143237. CCBUG: 143237 M +2 -2 imapaccountbase.cpp --- branches/KDE/3.5/kdepim/kmail/imapaccountbase.cpp #659644:659645 @@ -1070,10 +1070,10 @@ } } // if the only body part is not text, part->loadPart() would return false - // and that part is never loaded, so make sure it loads. + // and that part is never loaded, so make sure it loads. // it seems that TEXT does load the single body part even if it is not text/* if ( mBodyPartList.count() == 1 && partsToLoad == 0 ) - partsToLoad = 1; + partsToLoad = 1; // this causes the next test to succeed, and loads the whole message if ( (mBodyPartList.count() * 0.5) < partsToLoad ) { My original commit message was incomplete, both #93199 and #143237 were fixed by the one commit. > My original commit message was incomplete, both #93199 and #143237 were
> fixed by the one commit.
Ah OK, thanks!
..and I confirm, that applying this patch to various kdepim versions from 3.4.0 to 3.5.6 fixes this ugly issue without any adverse effects. Good work, Will. *** Bug 127214 has been marked as a duplicate of this bug. *** Version: 1.9.7 (KDE 3.5.7, Gentoo) Compiler: Target: i686-pc-linux-gnu OS: Linux (i686) release 2.6.18-gentoo-r3 I confirm the bug as described in comment #1 of bug 113516, which has been marked as a duplicate of this bug. In the list pane the paperclip icon is not shown for messages that consist of a single non-text/* part. Created attachment 23270 [details]
gzipped email that demonstrates the bug
Reopening so that the attachment indicator mentioned in comment #22 can be fixed SVN commit 1020581 by mkoller: BUG: 143237 Check for an attachment not only in the first BodyPart but in the Message itself if it has no first BodyPart. M +8 -9 kmmessage.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1020581 |