Bug 143232

Summary:	Hide/Show JavaScript Console menu item not updated correctly
Product:	[Applications] kst	Reporter:	Andrew Walker <arwalker>
Component:	general	Assignee:	kst
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	1.x
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Proposed patch

Description Andrew Walker 2007-03-19 20:58:19 UTC

Version:           HEAD (using KDE KDE 3.5.1)
Installed from:    Compiled From Sources
OS:                Linux

PROBLEM:

The Hide/Show JavaScript Console menu item does not always correctly reflect the current status of the JavaScript console

STEPS TO REPRODUCE:

Start Kst
If necessary enable the JavaScript extension
Select Tools... Show JavaScript Console
In the JavaScript console type Exit<Enter>
Select the Tools menu

RESULTS:

The menu item reads Hide JavaScript Console

EXPECTED RESULTS:

The menu item should read Show JavaScript Console


In order to display the JavaScript Console the user must select Tools... Hide JavaScript Conolse followed by Tools... Show JaveScript Console

Comment 1 Andrew Walker 2007-03-22 18:00:47 UTC

Created attachment 20071 [details]
Proposed patch

No longer use an invalid signal

Comment 2 George Staikos 2007-03-22 18:04:08 UTC

Fine with me.
--
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/

Comment 3 Andrew Walker 2007-03-22 18:33:18 UTC

SVN commit 645470 by arwalker:

BUG:143232 Do not use an invalid signal to notify of the closure of the JavaScript console

 M  +1 -1      js.cpp  


--- trunk/extragear/graphics/kst/src/extensions/js/js.cpp #645469:645470
@@ -254,7 +254,7 @@
     _splitter->moveToLast(p->widget());
     app()->setCentralWidget(_splitter);
 
-    connect(p, SIGNAL(processExited()), this, SLOT(shellExited()));
+    connect(p, SIGNAL(destroyed()), this, SLOT(shellExited()));
     _konsolePart = p;
   }
   _splitter->show();