Bug 143109

Version:            (using KDE KDE 3.5.5)
Installed from:    Ubuntu Packages
OS:                Linux

-----
CASE:
-----

Let us consider a folder tree:

folder1
+- file1 1 MB
+- file2 1 MB
+- folder2
   +- file3 1 MB

--------------
QUERYING SIZE:
--------------
FIRST THE PROCEDURE THAT GIVES CORRECT RESULTS:

1. Now let us open folder1 in Konqueror and go to Tree View.
2. Let the subfolder folder2 be collapsed. 
3. Let us press Ctrl+A. file1, file2 and folder2 are selected.
4. Let us right-click the selected items and click on properties. 
5. The size of the files is shown as 3 MB. This is CORRECT.
6. Even if we had right-clicked on folder1 (by browsing to its parent directory) we would have got the same size.

NEXT THE MANIFESTATION OF THE BUG:

1. Now let us expand folder2 and hit Ctrl+A. This selects file1, file2, folder2 and file3. 
2. Now let us go to right-click properties.
3. We see 4 MB.
4. I presume this is because Konqueror is evaluating folder2's size and finds 1 MB, and then again file3 and finds 1 MB. Adding this to the sizes of file1 and file2 we get 4 MB.
5. If we go to folder1's parent, expand folder1 and select folder1 and its children and query their size, we would see similar meaningless results.

ADDITIONAL BUG RESULTING FROM PREVIOUS BUG:

1. Now let us collapse folder2 and press Ctrl+A.
2. Again let us go to right-click properties.
3. We still see 4 MB. This is inexplicable.

WHEN THIS CHILD-BUG GOES AWAY:

4. We move elsewhere in the same window and come back to folder1 and select file1, file2 and folder2.
5. We go to right-click properties.
6. Now we get back the 3 MB reading.
7. Perhaps the reason is that the size is cached in case repeated requests are made.

---------------------------------
ADDING AUDIO FILES TO A PLAYLIST:
---------------------------------

Now if these file1, file2 and file3 had been audio files, the following would also happen:

1. When folder2 is collapsed, if I drag file1, file2 and folder2 to Amarok, file1, file2 and file3 would be each added once to the playlist. This is CORRECT.
2. If I expand folder2 and select and drag file1, file2, folder2 and file3 to Amarok, file1 and file2 would each be added once and file3 would be added *twice*, just as in the previous case file3's size was evaluated twice - once for folder2 and once for itself.
3. If I have folder1 expanded (either to its direct children only or fully) and drag-drop it into Amarok, similar unintended results occur.

---------------
DELETING FILES: 
---------------

It also happens when I expand a tree in Konqueror, select the parents and children and hit Delete. KDE tries to delete the children after having deleted the parent and hence throws up an error saying it can't find the first child.

---------------------------------
EXTRACTING FILES FROM AN ARCHIVE:
---------------------------------

But this is not a Konqueror specific bug, since the same thing happens when I try to drag items from inside an archive opened in Ark to outside - whether the desktop or Konqueror or some other application is immaterial.

---------------------------------------------
CONCLUSION AND SUGGESTION FOR FIXING THE BUG:
---------------------------------------------

Ergo I conclude that this is a problem with the KTreeView class handling. If a parent and child item is selected, only one of the two should be processed, whichever is valid. 

1. If for every parent selected all its expanded children are selected, then it is sufficient to process the parent and one must ignore the children. For example in the above case if folder1, file1, file2 and folder2 is selected to be deleted and file3 is not expanded, then the application must stop with deleting folder1.

2. If for every parent selected all its expanded children are NOT selected, then only the children must be processed and not the parent. For example in the above case if folder1 and file1 are alone selected to be deleted, the operation must delete only file1. Or the application can throw up an error saying it is not possible to delete folder1 without deleting file2 and folder2 but they are not selected for deletion.

I hope this helps.