Bug 142882

Summary:	clearing the clipboard does not clear the clipboard history
Product:	[Unmaintained] klipper	Reporter:	Olivier Vitrat <ovit.debian>
Component:	general	Assignee:	Esben Mose Hansen <kde>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	nate
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Debian testing
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/plasma-workspace/-/commit/83fd08784ac6e099a35fd399a16da91b13c83bab	Version Fixed In:	6.2.0
Sentry Crash Report:

Description Olivier Vitrat 2007-03-12 19:29:34 UTC

Version:            (using KDE KDE 3.5.5)
Installed from:    Debian testing/unstable Packages

This has been reported in Debian BTS at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=410123

I think 'clear clipboard' should clear the clipboard history file.
(Currently, the file is only cleared if one empties the clipboard and
 then saves the empty clipboard on program exit.)

Suppose that, after using klipper for some days, user does two things:
 -- clears the clipboard
 -- changes from "save clipboard contents" to "don't save"

Then user's old, already-saved clipboard remains on file at
   ~/.kde/share/apps/klipper/history2.lst
and will happily remain there for months.

This is unlikely to be what the user wanted to achieve.  It's so
unexpected that it should probably be considered a 'normal' bug.

Comment 1 Nicholas Tung 2007-12-12 21:49:15 UTC

particularly not a good idea if people happen to copy passwords. perhaps defaults are the distro's responsibility, but if not, please change it to not save on exit by default.

Comment 2 Esben Mose Hansen 2009-09-21 21:21:57 UTC

SVN commit 1026419 by esben:

Clear on-disk clipboard history when either the user switches from saving history
to not, or when manually clearing history
BUG: 142882

 M  +13 -5     klipper.cpp  
 M  +2 -2      klipper.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1026419

Comment 3 Esben Mose Hansen 2010-01-19 19:50:24 UTC

SVN commit 1077232 by esben:

Clear on-disk clipboard history when either the user switches from saving history to not, or when manually clearing history 
CCBUG: 142882


 M  +12 -6     klipper.cpp  
 M  +2 -2      klipper.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1077232

Comment 4 Fushan Wen 2024-09-26 11:47:29 UTC

Git commit 06d417d9d98ac96c0795deb2bd283815e4a3a70f by Fushan Wen.
Committed on 26/09/2024 at 11:47.
Pushed by fusionfuture into branch 'master'.

klipper: fix clearing history when history is off

If user has save clipboard turned off, old data should be deleted from
disk.

M  +0    -4    klipper/historymodel.cpp

https://invent.kde.org/plasma/plasma-workspace/-/commit/06d417d9d98ac96c0795deb2bd283815e4a3a70f

Comment 5 Fushan Wen 2024-09-26 11:48:02 UTC

Git commit 83fd08784ac6e099a35fd399a16da91b13c83bab by Fushan Wen.
Committed on 26/09/2024 at 11:47.
Pushed by fusionfuture into branch 'Plasma/6.2'.

klipper: fix clearing history when history is off

If user has save clipboard turned off, old data should be deleted from
disk.


(cherry picked from commit 06d417d9d98ac96c0795deb2bd283815e4a3a70f)

Co-authored-by: Fushan Wen <qydwhotmail@gmail.com>

M  +0    -4    klipper/historymodel.cpp

https://invent.kde.org/plasma/plasma-workspace/-/commit/83fd08784ac6e099a35fd399a16da91b13c83bab