Bug 141601

Summary: file size not updated after inserting Metadata
Product: [Applications] digikam Reporter: Daniel Bauer <linux>
Component: Metadata-DateAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: marcel.wiesweg, mcguire
Priority: NOR    
Version: 0.9.1   
Target Milestone: ---   
Platform: openSUSE   
OS: Linux   
Latest Commit: Version Fixed In: 0.10.0
Sentry Crash Report:

Description Daniel Bauer 2007-02-12 18:15:15 UTC
Version:           0.9.1 svn (using KDE KDE 3.5.6)
Installed from:    SuSE RPMs
OS:                Linux

When adding Metadata to a jpg file the file gets larger, of course, but the display of the file size in album view is not updated unless you change to another album and back again.

(the newly added keyword is displayed, so the album view *is* updated, just not the file size).
Comment 1 Marcel Wiesweg 2007-02-12 23:01:46 UTC
The file size is cached in the image info object. Not only the album view is affected, but also the right side bar in album view and in the image editor, for all cached fields (date!, not tags, rating).
This requires some deeper changes in the way we currently use the ImageInfo objects.
Comment 2 Thomas McGuire 2007-02-14 20:46:20 UTC
This behavior is very problematic when changing the date of the picture using the right-hand side Comments/Tags tab.

The thumbnail view does not reflect the new date, so I first I thought the dates were not updated properly.

Additionally, when using the left-hand side Dates tab, changing the date of a picture should then put it into the correct category of the tab. For example, when I am viewing pictures of December 2006 and change the date of a picture to 26. November 2006, it should disappear from the thumbnail view (because we only want to see December 2006 pictures). It should only reappear when selecting November 2005 in the Dates tab.

Not seeing the effects of my date changes makes the date change feature unusable for me (and sadly I need to use that often because I had a broken camera regarding dates).
Comment 3 Thomas McGuire 2007-02-14 22:32:57 UTC
>Additionally, when using the left-hand side Dates tab, changing the date of a picture should then put it into the correct category of the tab. For example, when I am viewing pictures of December 2006 and change the date of a picture to 26. November 2006, it should disappear from the thumbnail view (because we only want to see December 2006 pictures). It should only reappear when selecting November 2005 in the Dates tab. 
 
Actually, I can no longer reproduce this, it now seems to work as it should. Strange...

Anyway, then only the problem that remains now is that the date shown in the thumbnail view is not immediately updated, only after switching albums.
Comment 4 Thomas McGuire 2007-02-15 02:46:31 UTC
It happend again. Seems like the pictures sometimes correctly rearrange themselves to the correct date folder, and sometimes don't. Note that this also does not work with search folders which have dates in their criteria, but again only sometimes.

Another thing which is not correctly updated is the file name after using the batch rename tool.
Comment 5 Thomas McGuire 2007-02-19 19:57:58 UTC
Additionally, the thumbnail, file size and everything else should be updated after editing a picture with showfoto.
I want to see the new thumbnail after improving my picture with the editor.
Comment 6 caulier.gilles 2008-12-05 21:52:19 UTC
Daniel,

It still valid using digiKam 0.9.4 ?

Gilles Caulier
Comment 7 Mikolaj Machowski 2008-12-06 17:46:02 UTC
Still exists in 0.9.5svn - although not always reproducible.

Interesting thing: when removing comment size of image isn't always decreasing and when decreasing it doesn't decrease by size of comment. During tests for this bug report with few similar comments (each 10-15 chars) image of size increased about one hundred bytes. Not bug per se but strange.
Comment 8 Mikolaj Machowski 2008-12-06 21:19:01 UTC
And in 0.10-beta7 I am completely unable to update file size. OK(?) - restart of digiKam did it.
Comment 9 Marcel Wiesweg 2008-12-13 19:11:17 UTC
SVN commit 896523 by mwiesweg:

When writing metadata, directly scan the file for db changes.
The dir watch does not always get subtle file changes that only
involve writing to an existing file.

CCBUG: 141601

 M  +11 -1     digikam/albumiconview.cpp  
 M  +5 -1      digikam/tagfilterview.cpp  
 M  +5 -1      digikam/tagfolderview.cpp  
 M  +7 -1      libs/imageproperties/imagedescedittab.cpp  
 M  +5 -1      libs/imageproperties/talbumlistview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=896523
Comment 10 Marcel Wiesweg 2008-12-13 19:42:09 UTC
Miko, for KDE4:
- we cannot always catch a file change if it is done from outside (with exiv2, exiftool in this case), see my last comment for bug 151552
- I have fixed some problems when changes are done from inside digikam.
  Please let me know if you still have situations where an action from digikam modifies the file size, but it is not updated in the icon view / right side bar
Comment 11 Mikolaj Machowski 2008-12-14 23:38:30 UTC
Size is updated. Original report is FIXED. There were additions in discussion - so I am leaving closing of this bug to the discretion of developers.
Comment 12 caulier.gilles 2008-12-15 11:50:09 UTC
Marcel, 

We can close this file for 0.10.0-beta7 ?

Gilles 
Comment 13 Marcel Wiesweg 2008-12-15 18:44:17 UTC
For me it's fine to close as fixed for KDE4.
Comment 14 caulier.gilles 2008-12-15 18:51:00 UTC
Ok. Fine. Another one for beta7...

Gilles