Bug 141564

Summary:	Check that destination is writable before preparing move/copy job
Product:	[Frameworks and Libraries] frameworks-kio	Reporter:	Bartemius Crouch <egxoun8uya67izy>
Component:	general	Assignee:	David Faure <faure>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugseforuns, dieseltrike, finex, geist1, kdedev, kdelibs-bugs-null, nate
Priority:	NOR	Keywords:	usability
Version First Reported In:	5.45.0
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	https://commits.kde.org/kio/1df333b33cc1ca3dabfceed27ea21e65f26e0f72	Version Fixed/Implemented In:	5.63
Sentry Crash Report:
Attachments:	What i saw when i came back

Description Bartemius Crouch 2007-02-11 23:56:04 UTC

Version:           3.5.5 (using KDE 3.5.5, Kubuntu (edgy) 4:3.5.5-0ubuntu3)
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.17-10-generic

Using Kubuntu 6.10 Live CD, i tried to copy 0.6 million files in 39998 or so folders to an external disk. After who knows how long it took to prepare for this, i come back to the computer to find the copy dialog saying "100% done" and the destination external HD screen having a dialog saying permission denied... Turns out the external HD was mounted as root. Why does Konqueror not check if an action is possible before spending half an hour (you tell me, the progress dialog didn't) wearing out my Windows drive.

Posting using bugmenot account because Konq froze when trying to access Hotmail for my password. - CT

Comment 1 Bartemius Crouch 2007-02-11 23:59:36 UTC

Created attachment 19632 [details]
What i saw when i came back

Comment 2 FiNeX 2008-06-02 00:26:21 UTC

Yes, kio should do some further test before starting the copy process.

Comment 3 Peter Penz 2009-09-07 08:45:09 UTC

*** Bug 206535 has been marked as a duplicate of this bug. ***

Comment 4 David Faure 2019-09-17 22:20:46 UTC

Git commit 1df333b33cc1ca3dabfceed27ea21e65f26e0f72 by David Faure.
Committed on 17/09/2019 at 22:20.
Pushed by dfaure into branch 'master'.

Move/copy job: skip stat'ing sources if the destination dir isn't writable

Summary: BUG: 141564

Test Plan: Unit test, but also copying to / in dolphin, to check what the error message looks like.

Reviewers: shubham, broulik, bruns, chinmoyr, ngraham

Reviewed By: ngraham

Subscribers: ngraham, chinmoyr, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D17632

M  +52   -0    autotests/jobtest.cpp
M  +2    -0    autotests/jobtest.h
M  +12   -1    src/core/copyjob.cpp

https://commits.kde.org/kio/1df333b33cc1ca3dabfceed27ea21e65f26e0f72

Comment 5 David Faure 2019-09-18 12:04:35 UTC

Git commit 54e2fe33c4d3eda37cd415fdb0923fe40b52b2f5 by David Faure.
Committed on 18/09/2019 at 12:03.
Pushed by dfaure into branch 'master'.

Amend commit 1df333b33cc to only fail early if no privilege escalation is possible

M  +1    -1    src/core/copyjob.cpp

https://commits.kde.org/kio/54e2fe33c4d3eda37cd415fdb0923fe40b52b2f5

Comment 6 Nate Graham 2019-09-21 21:20:17 UTC

*** Bug 412163 has been marked as a duplicate of this bug. ***