Summary: | Put %CURSOR at top of templates by default | ||
---|---|---|---|
Product: | [Unmaintained] kmail | Reporter: | Maciej Pilichowski <bluedzins> |
Component: | templates | Assignee: | kdepim bugs <kdepim-bugs> |
Status: | RESOLVED WAITINGFORINFO | ||
Severity: | wishlist | CC: | dmiceman, glua, luigi.toscano |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
Maciej Pilichowski
2007-02-09 21:46:54 UTC
This is caused by the new templates feature. Go into Configure KMail-> Composer -> Templates Select Reply to Sender. You'll see a %CURSOR in the template. Make the template look something like: %REM="Default reply template"%- %CURSOR On %ODATEEN %OTIMELONGEN you wrote: %QUOTE sorry, I will fix this by moving the %CURSOR up to the top of the template. so -> reopening. but you have a way to fix this yourself in the meantime. Yes, thank you very much. Isn't this fixed in KMail 1.9.7 by now? For me the cursor is placed at the top of mail. Mass-changing component to "templates" and adding original template author to CC list. SVN commit 700430 by tmcguire: Fix the cursor position for templates. Now %CURSOR works again, this was somehow lost in porting. Additionally, it is now possible again to set the cursor to the first line. BUG: 140917 CCBUG: 141459 M +2 -3 kmcomposewin.cpp M +8 -0 kmedit.cpp M +4 -0 kmedit.h --- trunk/KDE/kdepim/kmail/kmcomposewin.cpp #700429:700430 @@ -4635,9 +4635,8 @@ void KMComposeWin::setReplyFocus( bool hasMessage ) { mEditor->setFocus(); - if ( hasMessage ) { - mEditor->setCursorPosition( 1, 0 ); - } + if ( hasMessage ) + mEditor->setCursorPositionFromStart( (unsigned int) mMsg->getCursorPos() ); } void KMComposeWin::setFocusToSubject() --- trunk/KDE/kdepim/kmail/kmedit.cpp #700429:700430 @@ -759,4 +759,12 @@ } } +void KMEdit::setCursorPositionFromStart( unsigned int pos ) { + unsigned int l = 0; + unsigned int c = 0; + posToRowCol( pos, l, c ); + setCursorPosition( l, c ); + ensureCursorVisible(); +} + #include "kmedit.moc" --- trunk/KDE/kdepim/kmail/kmedit.h #700429:700430 @@ -91,6 +91,10 @@ unsigned int lineBreakColumn() const; + /** set cursor to absolute position pos */ + void setCursorPositionFromStart(unsigned int pos); + + signals: void spellcheck_done( int result ); void attachPNGImageData( const QByteArray &image ); Closing as WONTFIX. The default is that the cursor is at the end. It can be changed easily by the user so that the cursor is at the top. This is not the default as top-posting is discouraged. Thomas, I believe the last comment was supposed to be in the other report, right? >Thomas, I believe the last comment was supposed to be in the other report, right? If you mean comment #6, then yes. I CC'ed this bug report because it was related, as it fixed the extra newline when %CURSOR was at the beginning. By comment #7, I am not to sure about WONTFIX. Maybe convert this to a wish to set %CURSOR at the top by default? Yes, it would be nice :-) 1) to mimic the old behaviour 2) if you answer with quotes the natural way is to start from the beginning and answer piece by piece Reopening to change this to a wish Argh, should be wishlist, not minor. It seems that with Kmail 1.11 this feature got broken again - I set the "%CURSOR" and it did work just before fedora 10 pushed the kde 4.2 update. Working fine here using KMail Version 1.11.0 (Using KDE 4.2.00 (KDE 4.2.0)) Might be a Fedora packaging error. there's another template setup for each identity which is deactivated by default. somehow it has been activated by kde update from 4.1.4 to 4.2. Thank you for your feature request. Kmail1 is currently unmaintained so we are closing all wishes. Please feel free to reopen a feature request for Kmail2 if it has not already been implemented. Thank you for your understanding. Instead of creating a new feature request, please confirm here if the wishlist is still valid for kmail2. |