| Summary: | Quanta+ fails to create new remote directories on some FTP servers | ||
|---|---|---|---|
| Product: | [Unmaintained] quanta | Reporter: | Markus <darkvision> |
| Component: | general | Assignee: | András Manţia <amantia> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Markus
2007-02-05 19:57:56 UTC
Can you create a new directory on that server with Konqueror using the ftp:// protocol? Yes, that works without any problems. Markus I debugged this with my local server and Konqueror does not use a '/' at the end of the mkd command: [DEBUG] 257 "/" is your current location [DEBUG] Command [type] [I] [DEBUG] 200 TYPE is now 8-bit binary [DEBUG] Command [pasv] [] [DEBUG] 227 Entering Passive Mode (*******) [DEBUG] Command [list] [-la] [DEBUG] 150 Accepted data connection [DEBUG] 226-ASCII [DEBUG] 226-Options: -a -l [DEBUG] 226 2 matches total [DEBUG] Command [mkd] [/Test] [DEBUG] 257 "/Test" : The directory was successfully created Ok, this is new to me. Thanks for your help, I will fix the bug for the next version (3.5.7), but that won't appear soon. You will get a mail once it is fixed. SVN commit 630937 by amantia:
Fix directory creation when certain ftp servers are used.
BUG: 141232
M +4 -2 lib/qextfileinfo.cpp
M +5 -1 quanta/ChangeLog
M +10 -10 quanta/quanta.kdevelop
M +3 -1 quanta/utility/quantanetaccess.cpp
--- branches/KDE/3.5/kdewebdev/lib/qextfileinfo.cpp #630936:630937
@@ -192,6 +192,7 @@
{
int i = 0;
bool result;
+ KURL dir3;
KURL dir2;
KURL dir1 = path;
dir1.setPath("/");
@@ -211,8 +212,9 @@
dir2 = cdUp(dir2);
// debug(d1);
}
- // dir2.setPath(dir2.path(-1));
- result = KIO::NetAccess::mkdir(dir2, window);
+ dir3 = dir2;
+ dir3.adjustPath(-1); //some servers refuse to create directories ending with a slash
+ result = KIO::NetAccess::mkdir(dir3, window);
if (dir2.path() == "/" || !result)
break;
i++;
--- branches/KDE/3.5/kdewebdev/quanta/ChangeLog #630936:630937
@@ -1,7 +1,11 @@
This files contains the changes since Quanta 2.0 until the current 3.5.x series.
-Version 3.5.6 (Release date: xx-xx-2006; Started 01-09-2006):
+Version 3.5.7 (Release date: xx-xx-2006; Started 06-02-2006)
- bugfixes:
+ - fix directory creation when certain ftp servers are used [#141232]
+
+Version 3.5.6 (Release date: 26-01-2006; Started 12-10-2006):
+ - bugfixes:
- show Find in Files menu if KFileReplace is installed [related to #132530]
- fix various crashes in the debugger [#137483]
- fix crash when editing a <style> CSS area
--- branches/KDE/3.5/kdewebdev/quanta/quanta.kdevelop #630936:630937
@@ -17,8 +17,8 @@
<projectdirectory>.</projectdirectory>
<absoluteprojectpath>false</absoluteprojectpath>
<secondaryLanguages/>
- <versioncontrol></versioncontrol>
- <defaultencoding></defaultencoding>
+ <versioncontrol/>
+ <defaultencoding/>
<projectname>quanta</projectname>
</general>
<kdevautoproject>
@@ -184,7 +184,7 @@
</groups>
<tree>
<hidenonprojectfiles>false</hidenonprojectfiles>
- <hidepatterns/>
+ <hidepatterns></hidepatterns>
<showvcsfields>true</showvcsfields>
</tree>
</kdevfileview>
@@ -207,16 +207,16 @@
</kdevdoctreeview>
<kdevdebugger>
<general>
- <dbgshell></dbgshell>
+ <dbgshell/>
<programargs/>
<gdbpath>/usr/bin/gdb</gdbpath>
<breakonloadinglibs>true</breakonloadinglibs>
<separatetty>false</separatetty>
<floatingtoolbar>false</floatingtoolbar>
<runappinappdirectory>true</runappinappdirectory>
- <configGdbScript></configGdbScript>
- <runShellScript></runShellScript>
- <runGdbScript></runGdbScript>
+ <configGdbScript/>
+ <runShellScript/>
+ <runGdbScript/>
</general>
<display>
<staticmembers>false</staticmembers>
@@ -259,10 +259,10 @@
</kdevcvs>
<kdevfilecreate>
<filetypes>
- <type icon="" ext="h" name="C++ header" create="template" >
+ <type icon="" ext="h" create="template" name="C++ header" >
<descr>Quanta speicfic header</descr>
</type>
- <type icon="source_cpp" ext="cpp" name="C++ source" create="template" >
+ <type icon="source_cpp" ext="cpp" create="template" name="C++ source" >
<descr>A new empty C++ file.</descr>
</type>
</filetypes>
@@ -298,7 +298,7 @@
</codecompletion>
<references/>
<creategettersetter>
- <prefixGet></prefixGet>
+ <prefixGet/>
<prefixSet>set</prefixSet>
<prefixVariable>m_,_</prefixVariable>
<parameterName>theValue</parameterName>
--- branches/KDE/3.5/kdewebdev/quanta/utility/quantanetaccess.cpp #630936:630937
@@ -158,7 +158,9 @@
bool QuantaNetAccess::mkdir( const KURL & url, QWidget* window, int permissions, bool confirm )
{
- bool ok = KIO::NetAccess::mkdir( url, window, permissions );
+ KURL u = url;
+ u.adjustPath(-1); //some servers refuse to create directories ending with a slash
+ bool ok = KIO::NetAccess::mkdir( u, window, permissions );
if (ok) {
checkProjectInsert(url, window, confirm);
} else {
Hi... thanks for the patch. I applied it to Quanta 3.5.6 and tested upload of new directories. Seem to work. Markus |