Bug 141157

Summary:	Auto complete list breaks Non-ascii characters when there is a ioslave protocol in the address
Product:	[Applications] konqueror	Reporter:	David Lee <davidomundo>
Component:	general	Assignee:	Konqueror Developers <konq-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	aspotashev, finex
Priority:	NOR
Version:	4.8.3
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:	http://commits.kde.org/kdelibs/3bd3bca3eeeea1ef55db5d391d36bf07e423f97a	Version Fixed In:	4.9.1
Sentry Crash Report:
Attachments:	A file with name in Russian packed in a ZIP archive

Description David Lee 2007-02-04 11:20:45 UTC

Version:           3.5.5 (using KDE 3.5.5, Kubuntu (edgy) 4:3.5.5-0ubuntu3)
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.17-10-generic

In the address bar, it seems like Konqueror takes any address that starts with a protocol (ioslaves, ftp, etc) to be a http address, and escapes it as such when showing autocompletion. For instance, if I have files English_file.zip, 한글_file.zip, and 日本語_file.zip in /home/user, typing "/home/user/" in the Konqueror address bar would list:

/home/user/English_file.zip
/home/user/日本語_file.zip
/home/user/한글_file.zip

but if I have a protocol before it (such as zip:/), after typing "zip:/home/user/" the address bar would list:

/home/user/English_file.zip
/home/user/%E6%97%A5%E6%9C%AC%E8%AA%9E_file.zip
/home/user/%ED%95%9C%EA%B8%80_file.zip

I believe this also causes problems for the kioslaves themselves, as I had certain pathnames (which involve html-escaped characters) crash Konqueror when used with kioslaves. (Bug #141155)

Comment 1 Stefan Monov 2007-02-05 23:08:44 UTC

I can reproduce with KDE 3.5.6.

Comment 2 Rui G. 2008-06-01 18:24:20 UTC

I can reproduce it in 3.5.9 still. But in konqueror / dolphin at trunk it's hard to reproduce but I noted that there are problems with the characters as well. I could use autocomplete with konq4 and note the problem, but could not with dolphin.

Comment 3 Rui G. 2008-06-01 18:32:46 UTC

In konq4 works after all, but in dolphin autocomplete in zip:/ just works for folders.

Comment 4 FiNeX 2008-06-02 00:13:54 UTC

I confirm what Rui said id comment #2.

Comment 5 Médéric Boquien 2008-07-25 01:06:10 UTC

I can easily reproduce the bug in KDE 4.1 branch. For instance create the fōō file and it will be displayed as f%C5%8D%C5%8D in the autocompletion list when using the zip:/ io slave.

Comment 6 Myriam Schweingruber 2012-06-18 17:53:10 UTC

(In reply to comment #5)
> I can easily reproduce the bug in KDE 4.1 branch. For instance create the
> fōō file and it will be displayed as f%C5%8D%C5%8D in the autocompletion
> list when using the zip:/ io slave.

Closing for lack of feedback, This report is outdated, please feel free to reopen a new report if you can reproduce this with Konqueror 4.8.4 or later.

Comment 7 Alexander Potashev 2012-06-18 22:27:43 UTC

(In reply to comment #6)
> Closing for lack of feedback, This report is outdated, please feel free to
> reopen a new report if you can reproduce this with Konqueror 4.8.4 or later.

Myriam,

Why are you saying there is a lack of feedback for this bug report? As I understand, "lack of feedback" is when you have asked a question about details of the bug and cannot get any answer for a long time. So, what question was not answered in the discussion of this bug report?

I would never close a bug as "outdated"/"waiting for info"/"invalid" unless the description of the bug in the report is unclear and nobody is able to make it more specific. In the case of this bug report, the bug description is very clear and there is a step-wise procedure to reproduce it. Again, please do not close bugs for no good reason unless many people, in my opinion, would stop submitting bug reports since they get closed even before developers have seen it.

Comment 8 Alexander Potashev 2012-06-18 22:28:41 UTC

I can still reproduce this bug in KDE SC 4.8.3 on Gentoo Linux (x86_64) with the `zip:/` ioslave.

Comment 9 Alexander Potashev 2012-06-18 22:30:34 UTC

Created attachment 71926 [details]
A file with name in Russian packed in a ZIP archive

Comment 10 Martin Koller 2012-08-24 16:14:05 UTC

Git commit 3bd3bca3eeeea1ef55db5d391d36bf07e423f97a by Martin Koller.
Committed on 24/08/2012 at 18:08.
Pushed by mkoller into branch 'KDE/4.9'.

only percent encode what's needed to keep it human readable

Instead of fully percent encode the complete URL, use KUrl::prettyUrl()
which produces a human friendly format
FIXED-IN: 4.9.1
REVIEW: 106096

M  +16   -4    kio/kio/kurlcompletion.cpp

http://commits.kde.org/kdelibs/3bd3bca3eeeea1ef55db5d391d36bf07e423f97a