Summary: | immediate redraw of visited links makes page navigation noticably slower | ||
---|---|---|---|
Product: | [Applications] konqueror | Reporter: | Leo Savernik <l.savernik> |
Component: | khtml | Assignee: | Martin Koller <kollix> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | germain |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Leo Savernik
2007-01-28 14:38:09 UTC
Part of Mozilla's solution strategy may actually help khtml's, too: https://bugzilla.mozilla.org/show_bug.cgi?id=78510#c128 Please apply the partial revert now (with a CCMAIL:kde-packager@kde.org)... there's no reason to have everybody harmed while waiting for a proper solution. When I think this was in svn for 4 weeks before release and nobody noticed anything wrong! Clearly far too few people test branch. Meaningful development or backport cannot continue with such poor conditions. SVN commit 628618 by savernik: Reverting r617941. This fixes jumping to the top right before loading a new page and also fixes page loading time increase. Attention packagers! Please include this patch in new versions of your khtml-3.5.6 packages. Web surfing experience can be considered broken without it. CCMAIL: kde-packager@kde.org BUG: 140768 CCBUG: 140777 CCBUG: 24820 M +1 -1 html_documentimpl.cpp --- branches/KDE/3.5/kdelibs/khtml/html/html_documentimpl.cpp #628617:628618 @@ -222,7 +222,7 @@ void HTMLDocumentImpl::slotHistoryChanged() { - if ( !m_render ) + if ( true || !m_render ) return; recalcStyle( Force ); Reverted. How about requiring approval for non-core khtml committers' patches like in KDE 3.4-times? ... Oh, it *was* approved. Well, not sure how to maintain quality without deterring occasional committers from contributing. But maybe we've reached the time to become convervative about what's committed to the branch. (Just for the records: The original bug r617941 was about to fix was bug 24820.) |