Summary: | capacity auto-detection does not work | ||
---|---|---|---|
Product: | [Applications] k3b | Reporter: | Maciej Pilichowski <bluedzins> |
Component: | general | Assignee: | Sebastian Trueg <trueg> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
Maciej Pilichowski
2007-01-23 14:46:13 UTC
found this comment in my code. Sadly I do not really know what I mean by that. Stupid short comments! // FIXME: unless we do not know the real capacity of CD-RW media we can only // use empty here I will look into it. SVN commit 626495 by trueg: Since my comment is way to short and I cannot understand the reason anymore I just removed it and with it added support for CD-RW for auto project size detection. This should be a reminder for me to write proper comments. ;) BUG: 140494 M +1 -4 k3bfillstatusdisplay.cpp --- trunk/extragear/multimedia/k3b/src/projects/k3bfillstatusdisplay.cpp #626494:626495 @@ -672,9 +672,6 @@ // TODO: once we have only one data project we need to change this to handle both - // FIXME: unless we do not know the real capacity of CD-RW media we can only use - // empty here - K3bDevice::Device* dev = 0; QPtrList<K3bDevice::Device> devs; if( d->showDvdSizes ) @@ -687,7 +684,7 @@ if( ( medium.diskInfo().empty() || medium.diskInfo().appendable() || - (medium.diskInfo().rewritable() && medium.diskInfo().isDvdMedia()) ) && + medium.diskInfo().rewritable() ) && ( medium.diskInfo().isDvdMedia() == d->showDvdSizes ) && d->doc->length() <= medium.diskInfo().capacity() ) { |