Bug 140466

Summary:	Search functionality in data manager is too general
Product:	[Applications] kst	Reporter:	Andrew Walker <arwalker>
Component:	general	Assignee:	kst
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	1.x
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Andrew Walker 2007-01-23 00:18:57 UTC

Version:           HEAD (using KDE KDE 3.5.1)
Installed from:    Compiled From Sources
OS:                Linux

PROBLEM:

The search functionality in the data manager searches for a match to the text entered in all fields of the data manager (type, samples, and properties) in addition to the name.

I would have expected that the search applies only to the name and to do otherwise seems confusing, especially as the number of entries grows.

Comment 1 George Staikos 2007-01-23 03:06:28 UTC

SVN commit 626381 by staikos:

Only search column 0.  Is this really what we want?  I'm not convinced either
way right now, but at least this shows how to solve the problem
BUG: 140466


 M  +4 -0      kstdatamanager_i.cpp  


--- trunk/extragear/graphics/kst/src/libkstapp/kstdatamanager_i.cpp #626380:626381
@@ -614,6 +614,10 @@
   connect(DataView, SIGNAL(contextMenuRequested(QListViewItem*, const QPoint&, int)), this, SLOT(contextMenu(QListViewItem*, const QPoint&, int)));
 
   _searchWidget = new KListViewSearchLineWidget(DataView, SearchBox);
+  QValueList<int> cols;
+  cols.append(0);
+  _searchWidget->createSearchLine(DataView);
+  _searchWidget->searchLine()->setSearchColumns(cols);
 
   QMainWindow *main = static_cast<QMainWindow*>(parent);
   main->setUsesTextLabel(true);

Comment 2 Nicolas Brisset 2007-01-23 10:30:10 UTC

As I said on the list, I think it is *necessary* to be able to filter by type as well. One of my proposals was to allow multiple (comma-separated) strings as in "vector, phi" to list all vectors containing phi. I recognize that this is not very intuitive (even though a tooltip might be enough to give users a hint), but it allows all sorts of filterings which users around here keep asking for while keeping a simple UI. If we don't do that, then we have to add combo boxes or something else to allow selecting the type at least, and possibly other attributes (like datasource for instance, which is quite useful). I think we'll end up with a pretty complex UI and that's why I maintain my proposal for a comma-separated list of keywords. What I don't know is whether KListViewSearchLineWidget supports regexps...

Comment 3 George Staikos 2007-01-23 10:43:03 UTC

Just leave this bug as closed.  Searching all fields is a problem.  It makes search almost useless in the common case.  The search line only supports basic searching.  Beyond that we have to implement something ourselves.