Bug 140281

Summary:	Global default for ToolBar "Text position" doesn't work
Product:	[Unmaintained] kdeprint	Reporter:	James Richard Tyrer <tyrerj>
Component:	general	Assignee:	KDEPrint Devel Mailinglist <kde-print-devel>
Status:	RESOLVED UNMAINTAINED
Severity:	normal	CC:	jlayt
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description James Richard Tyrer 2007-01-19 08:55:34 UTC

Version:            (using KDE KDE 3.5.5)
Installed from:    Compiled From Sources
Compiler:          GCC-4.1.1 
OS:                Linux

The global default setting for "Text position" --

In the Control Center: "Appearance & Themes -> Style"

on the "Toolbar" -- 

Does NOT effect the ToolBars in KDEPrint.

Specifically when this is set to: "Icons Only", KDEPRINT ToolBars still have text.

Specific issue which I have is with the preview window.  Using Arial Narrow 12, the window is too wide for my 1024x768 display at 100 DPI.

Comment 1 Maciej Pilichowski 2007-01-20 08:47:04 UTC

To be 100% sure -- how do you get to the dialog (kdeprint) you are talking about?

Comment 2 James Richard Tyrer 2007-01-20 09:04:58 UTC

For example, while displaying an HTML document in Konqueror: 
 
"Location -> Print" 
 
Then the Print dialog window comes up. 
 
Check the: "Preview" box in the upper right area and click the: "Print" button at the bottom. 
 
Then the preview window comes up which is too wide for my screen.

Also see screen shots in Bug #140283

Comment 3 Kurt Pfeifle 2007-01-20 20:20:42 UTC

James, please see also my comments for bug 140283. 

If you prefer kghostview for print previews, set it up as the external preview application, and it will show up with more controls for you.

That's at least an easy workaround for now (as long as there is no-one with time to work on the code).

In any case: please proof to me with a reference to the code that this is a KDEPrint bug (instead of a Konqueror or kdelibs bug), or move the report to the appropriate module.

Cheers,
Kurt

Comment 4 James Richard Tyrer 2007-01-21 00:51:15 UTC

Re: Comment #3

It appears to me that using an external application isn't possible, it only uses a KPart for preview.

I observe the following:

It always uses the choice for "Embedding" even if: "Show file in separate viewer" is chosen for the MIME type application/postscript.

If nothing is chosen for "Embedding", it uses KGhostView. 

Note that using the choice for "Embedding" is a bug not a feature.  E.G. choose "Embedded Advanced Text Editor" and see what happens -- no print preview.

The problem remains that somehow when KDEPrint uses the KPart to display the PS file that the global default setting for: "Text position" isn't used.  This is the case no matter what KPart is chosen.

Comment 5 Michael Goffioul 2007-01-22 09:39:34 UTC

This was intentional. See http://websvn.kde.org/trunk/KDE/kdelibs/kdeprint/kprintpreview.cpp?rev=621518&view=auto in function KPrintPreview::initView(). The style for the toolbar is explicitely set.

I did this to make the print preview clearer as (at the time I wrote that code, which means a few years ago) I found the single icons weren't very meaningful about their associated action.

What you can try is to comment the line with "d->toolbar_->setToolButtonStyle"
and recompile to see if it works as expected.

Comment 6 John Layt 2011-05-27 18:26:28 UTC

KDEPrint is obsolete, unmaintained and will never be revived.  Closing all open bugs.