| Summary: | kdepim 3.5.6 compilation failure in kpilot errors in vcalRecord.cc | ||
|---|---|---|---|
| Product: | [Unmaintained] kpilot | Reporter: | Elan Ruusamäe <glen> |
| Component: | General | Assignee: | groot |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Elan Ruusamäe
2007-01-17 20:16:59 UTC
maybe this helps:
kpilot/conduits/vcalconduit/vcalRecord.cc:
void VCalRecord::setCategory(PilotDateEntry *de, const KCal::Event *e)
{
...
if (eventCategories.size() < 1)
{
// This event has no categories.
line 587: de->setCategory(Pilot::Unfiled);
kpilot/lib/pilot.h:
namespace Pilot
{
...
/** Category number for unfiled records */
static const int Unfiled = 0;
kpilot/lib/pilotDateEntry.h:
/** This class is a wrapper for pilot-link's datebook entries (struct Appointment). */
class KDE_EXPORT PilotDateEntry : public PilotRecordBase
{
...
inline bool setCategory(const QString &label)
{
int c = Pilot::insertCategory(&fAppInfo.category,label,false);
PilotRecordBase::setCategory(c);
return c>=0;
} ;
On Wednesday 17 January 2007 20:22, Elan RuusamXXe wrote: > maybe this helps: > > line 587: de->setCategory(Pilot::Unfiled); It does, thank you. I'm test-compiling something now. SVN commit 624745 by adridg:
Fix compile error w/ base class methods not being called.
BUG: 140207
M +1 -1 vcalRecord.cc
--- branches/KDE/3.5/kdepim/kpilot/conduits/vcalconduit/vcalRecord.cc #624744:624745
@@ -584,7 +584,7 @@
if (eventCategories.size() < 1)
{
// This event has no categories.
- de->setCategory(Pilot::Unfiled);
+ (PilotRecordBase *)de->setCategory(Pilot::Unfiled);
return;
}
it did not fix the problem
vcalRecord.cc: In static member function `static void
VCalRecord::setCategory(PilotDateEntry*, const KCal::Event*)':
vcalRecord.cc:587: error: invalid conversion from `int' to `const char*'
vcalRecord.cc:587: error: initializing argument 1 of `QString::QString(const
char*)'
vcalRecord.cc:626: error: invalid conversion from `int' to `const char*'
vcalRecord.cc:626: error: initializing argument 1 of `QString::QString(const
char*)'
make[4]: *** [vcalRecord.lo] Error 1
make[4]: Leaving directory `/home/builder/rpm/pld/BUILD/kdepim-3.5.6/kpilot/conduits/vcalconduit'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/home/builder/rpm/pld/BUILD/kdepim-3.5.6/kpilot/conduits'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/builder/rpm/pld/BUILD/kdepim-3.5.6/kpilot'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/builder/rpm/pld/BUILD/kdepim-3.5.6'
make: *** [all] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.45164 (%build)
RPM build errors:
Bad exit status from /var/tmp/rpm-tmp.45164 (%build)
Error: package build failed. (no more info)
$ grep -n . vcalRecord.cc|grep 587:
587: (PilotRecordBase *)de->setCategory(Pilot::Unfiled);
$ grep -n . vcalRecord.cc|grep 626:
626: de->setCategory(Pilot::Unfiled);
used qt/gcc:
qt-3.3.7-1.amd64
gcc-3.3.6-4.amd64
perhaps it's gcc version problem because i heard success on newer gcc:
qt-3.3.7-5.i686
gcc-4.2.0-0.20070106r120523.1.i686
hello, this fixes the compile problem now on gcc-3.3.6: http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/SOURCES/kdepim-bug-140207.patch?rev=1.3 SVN commit 624937 by adridg:
Fix casting following patch from pl-
BUG: 140207
M +2 -2 vcalRecord.cc
--- branches/KDE/3.5/kdepim/kpilot/conduits/vcalconduit/vcalRecord.cc #624936:624937
@@ -584,7 +584,7 @@
if (eventCategories.size() < 1)
{
// This event has no categories.
- (PilotRecordBase *)de->setCategory(Pilot::Unfiled);
+ ((PilotRecordBase *)de)->setCategory(Pilot::Unfiled);
return;
}
@@ -623,6 +623,6 @@
}
}
- de->setCategory(Pilot::Unfiled);
+ ((PilotRecordBase *)de)->setCategory(Pilot::Unfiled);
}
|