Bug 139460

Summary: amarok script manager do not handle dots in script's name
Product: [Applications] amarok Reporter: Gioele Barabucci <dev>
Component: generalAssignee: Amarok Developers <amarok-bugs-dist>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 1.4.4   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Gioele Barabucci 2007-01-01 07:46:31 UTC 
Version:           1.4.4 (using KDE 3.5.5, Gentoo)
Compiler:          Target: powerpc-unknown-linux-gnu
OS:                Linux (ppc) release 2.6.19-gentoo-r2

If a script have a dot in its name, its .spec file will not read.

Probably because amarok splits foo.org.rb in foo,org.rb and searches for foo.spec instead of foo.org,rb and foo.org.spec.
Comment 1 Martin Aumueller 2007-01-03 00:13:05 UTC 
SVN commit 619194 by aumuell:

assume that only the last dot of a script executable is not part of the script name
BUG: 139460


 M  +2 -0      ChangeLog  
 M  +2 -2      src/scriptmanager.cpp  


--- trunk/extragear/multimedia/amarok/ChangeLog #619193:619194
@@ -87,6 +87,8 @@
     * Amarok now saves playlists with relative paths by default.
 
   BUGFIXES:
+    * Assume that all dots but the last in script executable files belong to
+      the script name. (BR 139460)
     * Don't crash when quitting while initially loading the playlist.
       (BR 136353)
     * The same track could be queued multiple times for transferring to a
--- trunk/extragear/multimedia/amarok/src/scriptmanager.cpp #619193:619194
@@ -279,7 +279,7 @@
     if( !m_scripts.contains( name ) )
         return QString::null;
     QFileInfo info( m_scripts[name].url.path() );
-    const QString specPath = info.dirPath() + '/' + info.baseName() + ".spec";
+    const QString specPath = info.dirPath() + '/' + info.baseName( true ) + ".spec";
 
     return specPath;
 }
@@ -843,7 +843,7 @@
         // Read and parse .spec file, if exists
         QFileInfo info( path );
         KListViewItem* li = 0;
-        const QString specPath = info.dirPath() + '/' + info.baseName() + ".spec";
+        const QString specPath = info.dirPath() + '/' + info.baseName( true ) + ".spec";
         if( QFile::exists( specPath ) ) {
             KConfig spec( specPath, true, false );
             if( spec.hasKey( "name" ) )