Bug 138781

Summary: Implement /kill
Product: [Applications] konversation Reporter: Niklas Boelter <niklas>
Component: generalAssignee: Konversation Developers <konversation-devel>
Status: RESOLVED FIXED    
Severity: wishlist    
Priority: NOR    
Version: 1.0.1   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Niklas Boelter 2006-12-14 00:05:55 UTC 
Version:           1.0.1 (using KDE KDE 3.5.5)
Installed from:    Ubuntu Packages
OS:                Linux

Konversation does not add a colon before the last parameter of the KILL command, so the server only parses the last word as Kill Message.

Example:
User Enters /Kill Waldi Test1 Test2
Rawlog:
[23:56:03] << KILL Waldi Test1 Test2
[23:56:03] >> :bloodsport.xchannel.org NOTICE * :*** Notice -- Received KILL message for Waldi. From niklasboelter Path: ***********.net!niklasboelter (Test2)

Expected behavior:
[23:56:03] << KILL Waldi :Test1 Test2
[23:56:03] >> :bloodsport.xchannel.org NOTICE * :*** Notice -- Received KILL message for Waldi. From niklasboelter Path: ***********.net!niklasboelter (Test1 Test2)

[http://tools.ietf.org/html/rfc1459#section-4.6.1]
Comment 1 Eike Hein 2006-12-14 01:39:36 UTC 
/kill isn't implemented at the moment; adapting bug.
Comment 2 Peter Simonsson 2006-12-23 00:34:25 UTC 
Implemented in trunk, rev 615863. Will be released in 1.1.
Comment 3 Niklas Boelter 2006-12-23 02:21:51 UTC 
I think there is a bug at this line:
result.toServer = "KILL " + victim + " :" + parameter.right(victim.length());
it should be the rest of the string, so
result.toServer = "KILL " + victim + " :" + parameter.right(parameter.length()-(1 + victim.length()));
would be better.

[Sorry for any mistakes, I have never used C++ before, but I hope you got the point.]
Comment 4 Peter Simonsson 2006-12-23 09:34:03 UTC 
Bah shows I shouldn't develop late at night... :(
The correct solution is to use mid instead of right, thx for reporting it's fixed now (as of rev 615913). :)