Bug 138776

Summary:	View Fit Results menu doesn't enable when a fit is created
Product:	[Applications] kst	Reporter:	Eli Fidler <eli>
Component:	general	Assignee:	kst
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	1.x
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Eli Fidler 2006-12-13 22:10:54 UTC

Version:           svn-trunk (using KDE KDE 3.5.5)
Installed from:    SuSE RPMs
OS:                Linux

After creating a fit (using the old plugin system), the View Fit Results menu (under Data) is still disabled.

Comment 1 Adam Treat 2006-12-13 22:31:09 UTC

Are you creating the fit via the RMB plot menu dialog?  When I create one this way the View Fit Results menu is enabled...

When I create via the datamanager, I get a deadlock... possibly related to 612802??

Comment 2 Eli Fidler 2006-12-13 23:11:22 UTC

I'm creating them using the New Plugin menu option under Data. Creating them 
under the data manager works for me (there was a deadlock I fixed), but the 
menu is still disabled. It looks like the dataChanged() signal is not being 
emitted.

I just tried to create a fit from the RMB menu and Kst crashes nastily. I 
appear to have broken that. Ok.. I fixed the crash, but the menu item is 
still disabled.

I suppose it's possible that this only happens in my branch, although George 
thinks it should happen in trunk as well.

Eli

On Wednesday 13 December 2006 16:31, Adam Treat wrote:
[bugs.kde.org quoted mail]

Comment 3 Adam Treat 2006-12-13 23:18:53 UTC

Yes, when your deadlock fix is applied to trunk the bug reveals itself.  Also, I don't get a crash when using the RMB menu in your branch.  Instead, the proper curve is not detected by the fitdialog.  Apparently this is due to some changes with the tags handling...

I'll apply your deadlock fix to my local copy and go from there.

Comment 4 Adam Treat 2006-12-13 23:21:44 UTC

BTW, I think your deadlock fix in hierarchy solves bug #135548 :)

Should this be applied to trunk before the merge of your branch?

Comment 5 Adam Treat 2006-12-14 01:14:41 UTC

SVN commit 613549 by treat:

* And today is that lucky day...

BUG:138776


 M  +1 -3      kst.cpp  


--- trunk/extragear/graphics/kst/src/libkstapp/kst.cpp #613548:613549
@@ -2172,12 +2172,10 @@
     if (!onlyVisible || changeNptsDialog->isShown()) {
       changeNptsDialog->updateChangeNptsDialog();
     }
-    if (!onlyVisible) { // FIXME: might want to make this sensible one day
-      updateDataDialogs(false);
-    }
     if (!onlyVisible || vectorSaveDialog->isShown()) {
       vectorSaveDialog->init();
     }
+    updateDataDialogs(false);
     updateDataManager(onlyVisible);
     updateViewManager(onlyVisible);
 #ifdef BENCHMARK

Comment 6 Peter Kümmel 2010-08-14 14:41:02 UTC

Change version to 1.x